New issue
Advanced search Search tips

Issue 793877 link

Starred by 1 user
Status: Fixed
Owner:
est...@chromium.org
Closed: Feb 2018
Cc:
xiy...@chromium.org
jamescook@chromium.org
sky@chromium.org
steve...@chromium.org
mustash-bugs@google.com
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

blocking i/o for some notifications (GetSignInProfile)

Project Member Reported by est...@chromium.org, Dec 11 2017 
Here we started using the Chrome OS SignInProfile for non-profile-specific notifications (currently only the captive portal one): https://chromium.googlesource.com/chromium/src/+/5d6e4694731cf80a222354f10a99fc467536da99

If the profile is not already loaded, like when you skip the login manager because you're recovering from a crash (or you're in guest mode?), this profile will not exist so it's loaded synchronously. This would be a potential source of jank, although it's probably fairly rare.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea9be28fa03084beb3137881a77ce6f3cd11ddc2

commit ea9be28fa03084beb3137881a77ce6f3cd11ddc2
Author: Evan Stade <estade@chromium.org>
Date: Tue Feb 06 18:32:31 2018

Support user-agnostic notifications in NotificationDisplayService

Create an NDS for a generic/"system" profile on demand and
asynchronously to service notification requests that aren't tied to
a particular user. Apply this to WebUsbDetector, and also update
some Chrome OS specific notifications which had been doing pretty
much the same thing, but had assumed/forced synchronicity.

Bug:  783018 ,  793877 
Change-Id: I95f4434bd6557bf846f5ed89052d4cff7f6bcf21
Reviewed-on: https://chromium-review.googlesource.com/891488
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534729}
[modify] https://crrev.com/ea9be28fa03084beb3137881a77ce6f3cd11ddc2/chrome/browser/BUILD.gn
[modify] https://crrev.com/ea9be28fa03084beb3137881a77ce6f3cd11ddc2/chrome/browser/chromeos/net/network_portal_notification_controller.cc
[modify] https://crrev.com/ea9be28fa03084beb3137881a77ce6f3cd11ddc2/chrome/browser/chromeos/ui/low_disk_notification.cc
[modify] https://crrev.com/ea9be28fa03084beb3137881a77ce6f3cd11ddc2/chrome/browser/notifications/notification_platform_bridge_chromeos.cc
[add] https://crrev.com/ea9be28fa03084beb3137881a77ce6f3cd11ddc2/chrome/browser/notifications/system_notification_helper.cc
[add] https://crrev.com/ea9be28fa03084beb3137881a77ce6f3cd11ddc2/chrome/browser/notifications/system_notification_helper.h
[modify] https://crrev.com/ea9be28fa03084beb3137881a77ce6f3cd11ddc2/chrome/browser/ui/ash/network/network_state_notifier.cc
[modify] https://crrev.com/ea9be28fa03084beb3137881a77ce6f3cd11ddc2/chrome/browser/usb/web_usb_detector.cc
[modify] https://crrev.com/ea9be28fa03084beb3137881a77ce6f3cd11ddc2/chrome/browser/usb/web_usb_detector_unittest.cc

Comment 2 by est...@chromium.org, Feb 17 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment