New issue
Advanced search Search tips

Issue 793857 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR

Blocked on:
issue 793430



Sign in to add a comment

window.rAF continues to fire during WebVR presentation in CCT/WAA

Project Member Reported by bsheedy@chromium.org, Dec 11 2017

Issue description

window.requestAnimationFrame is supposed to stop firing during WebVR presentation on Android. This is currently the case in regular Chrome (ChromeTabbedActivity), but Chrome Custom Tabs (CustomTabActivity) and Webapps (WebappActivity) continue to fire window.rAF.
 
Labels: M-65
Adding milestone so it doesn't slip off our radar.
Components: Blink>Scheduling
This seems to be arguing for the opposite of  bug 716647  -- can you clarify what the intended behavior is?
window.rAF should fire only when the page is visible.  issue 716647  tracks adding a test to ensure that it's fired on desktop, but not on Android (because on desktop the page is still visible, while on Android it isn't).
Blockedon: 793430
I think I know what the problem is, and I think it should be fixed with the fallback UI path.
Status: Fixed (was: Available)
Pretty sure this is fixed. Please re-open if it isn't.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/330651dccd5c85400655080c564a2d3aba8e57f0

commit 330651dccd5c85400655080c564a2d3aba8e57f0
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Jan 16 19:32:11 2018

Enable VR window.rAF test in all activities

Enables WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting in
all activity types that support VR since the bug that was causing it to
fail in CustomTabActivity/WebappActivity has been fixed.

Bug:  793857 
Change-Id: Icd463507366853b5e929d548ef03aa4371f7e057
Reviewed-on: https://chromium-review.googlesource.com/868452
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529488}
[modify] https://crrev.com/330651dccd5c85400655080c564a2d3aba8e57f0/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java

Labels: Test-Complete
Labels: VR-Caught-By-Test
Components: Internals>XR
Labels: -VR-Caught-By-Test XR-Caught-By-Test

Sign in to add a comment