Printing to XPS Document triggers a DCHECK |
||
Issue descriptionPrinting to XPS Document triggers a DCHECK if not specifying the --debug-print flag: [19244:18780:1211/090115.754:FATAL:printed_document.cc(246)] Check failed: !g_debug_dump_info.Get().empty(). Backtrace: base::debug::StackTrace::StackTrace [0x0000000000853818+104] (D:\chromium\src\base\debug\stack_trace_win.cc:286) base::debug::StackTrace::StackTrace [0x000000000085245F+31] (D:\chromium\src\base\debug\stack_trace.cc:199) logging::LogMessage::~LogMessage [0x00000000008C9633+131] (D:\chromium\src\base\logging.cc:581) printing::PrintedDocument::CreateDebugDumpPath [0x0000000021FE84C7+247] (D:\chromium\src\printing\printed_document.cc:249) printing::PrintingContextWin::NewDocument [0x00000000220105C1+673] (D:\chromium\src\printing\printing_context_win.cc:266) printing::PrintJobWorker::StartPrinting [0x000000000DB66C01+1201] (D:\chromium\src\chrome\browser\printing\print_job_worker.cc:297) base::internal::FunctorTraits<void (printing::PrintJobWorker::*)(printing::PrintedDocument *),void>::Invoke<printing::PrintJobWorker *,printing::PrintedDocument *> [0x000000000DA292C6+70] (D:\chromium\src\base\bind_internal.h:211) base::internal::InvokeHelper<0,void>::MakeItSo<void (printing::PrintJobWorker::*const &)(printing::PrintedDocument *),printing::PrintJobWorker *,printing::PrintedDocument *> [0x000000000DA291CD+77] (D:\chromium\src\base\bind_internal.h:294) base::internal::Invoker<base::internal::BindState<void (printing::PrintJobWorker::*)(printing::PrintedDocument *),base::internal::UnretainedWrapper<printing::PrintJobWorker>,base::internal::RetainedRefWrapper<printing::PrintedDocument> >,void ()>::RunImpl [0x000000000DA2914B+123] (D:\chromium\src\base\bind_internal.h:368) base::internal::Invoker<base::internal::BindState<void (printing::PrintJobWorker::*)(printing::PrintedDocument *),base::internal::UnretainedWrapper<printing::PrintJobWorker>,base::internal::RetainedRefWrapper<printing::PrintedDocument> >,void ()>::Run [0x000000000DA28FDD+61] (D:\chromium\src\base\bind_internal.h:350) base::RepeatingCallback<void ()>::Run [0x00000000077097B2+66] (D:\chromium\src\base\callback.h:94) printing::`anonymous namespace'::HoldRefCallback [0x000000000DA250E8+24] (D:\chromium\src\chrome\browser\printing\print_job.cc:43) base::internal::FunctorTraits<void (*)(const scoped_refptr<printing::PrintJobWorkerOwner> &, const base::RepeatingCallback<void ()> &),void>::Invoke<const scoped_refptr<printing::PrintJob> &,const base::RepeatingCallback<void ()> &> [0x000000000DA29D46+102] (D:\chromium\src\base\bind_internal.h:166) base::internal::InvokeHelper<0,void>::MakeItSo<void (*const &)(const scoped_refptr<printing::PrintJobWorkerOwner> &, const base::RepeatingCallback<void ()> &),const scoped_refptr<printing::PrintJob> &,const base::RepeatingCallback<void ()> &> [0x000000000DA29C2D+77] (D:\chromium\src\base\bind_internal.h:294) base::internal::Invoker<base::internal::BindState<void (*)(const scoped_refptr<printing::PrintJobWorkerOwner> &, const base::RepeatingCallback<void ()> &),scoped_refptr<printing::PrintJob>,base::RepeatingCallback<void ()> >,void ()>::RunImpl<void (*const [0x000000000DA29BAF+111] (D:\chromium\src\base\bind_internal.h:368) base::internal::Invoker<base::internal::BindState<void (*)(const scoped_refptr<printing::PrintJobWorkerOwner> &, const base::RepeatingCallback<void ()> &),scoped_refptr<printing::PrintJob>,base::RepeatingCallback<void ()> >,void ()>::Run [0x000000000DA29A4D+61] (D:\chromium\src\base\bind_internal.h:350) base::OnceCallback<void ()>::Run [0x00000000007D371E+94] (D:\chromium\src\base\callback.h:65) base::debug::TaskAnnotator::RunTask [0x0000000000857F8A+778] (D:\chromium\src\base\debug\task_annotator.cc:55) base::internal::IncomingTaskQueue::RunTask [0x0000000000907550+224] (D:\chromium\src\base\message_loop\incoming_task_queue.cc:129) base::MessageLoop::RunTask [0x000000000091290A+986] (D:\chromium\src\base\message_loop\message_loop.cc:391) base::MessageLoop::DeferOrRunPendingTask [0x0000000000913410+80] (D:\chromium\src\base\message_loop\message_loop.cc:406) base::MessageLoop::DoWork [0x0000000000913751+529] (D:\chromium\src\base\message_loop\message_loop.cc:447) base::MessagePumpDefault::Run [0x000000000091F454+100] (D:\chromium\src\base\message_loop\message_pump_default.cc:37) base::MessageLoop::Run [0x0000000000911FF3+547] (D:\chromium\src\base\message_loop\message_loop.cc:344) base::RunLoop::Run [0x0000000000A1B753+531] (D:\chromium\src\base\run_loop.cc:133) base::Thread::Run [0x0000000000B1BA19+393] (D:\chromium\src\base\threading\thread.cc:256) base::Thread::ThreadMain [0x0000000000B1C4C0+1328] (D:\chromium\src\base\threading\thread.cc:338) base::`anonymous namespace'::ThreadFunc [0x0000000000AE6C8C+412] (D:\chromium\src\base\threading\platform_thread_win.cc:91) BaseThreadInitThunk [0x00007FFE28D78364+20] RtlUserThreadStart [0x00007FFE2B7E7091+33] when specifying the flag, it does not DCHECK but the dialog to chose where to save the XPS file does not appear. It seems this was introduced with https://chromium-review.googlesource.com/804178
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0de489249045b999b89dadb1e04713261eca20ab commit 0de489249045b999b89dadb1e04713261eca20ab Author: rbpotter <rbpotter@chromium.org> Date: Mon Dec 11 21:55:27 2017 Printing: Fix DCHECK https://crrev.com/c/804178 added one too many DCHECKs, and it fails on Windows. Bug: 793850 Change-Id: I1e61cd3253dce2dadb84f40b4c873ac2978219e7 Reviewed-on: https://chromium-review.googlesource.com/818494 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#523224} [modify] https://crrev.com/0de489249045b999b89dadb1e04713261eca20ab/printing/printed_document.cc
,
Dec 12 2017
,
Dec 12 2017
Issue 794023 has been merged into this issue. |
||
►
Sign in to add a comment |
||
Comment 1 by rbpotter@chromium.org
, Dec 11 2017