New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793799 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit 28 days ago
Closed: Dec 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

"url" field in index sourcemap section is not supported

Reported by mike.ade...@gmail.com, Dec 11 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce the problem:
In index source map, every section have either "map" or "url" property.
ATM devtools support only "map" property.

In case of "url" property, the sourcemap for the section should be downloaded from that url.

SourceMap spec: https://goo.gl/vtEVF

What is the expected behavior?
Chrome supports the spec as written by Google.

What went wrong?
The source map does not work. The error message is not helpful.

Did this work before? No 

Chrome version: 62.0.3202.94  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

This was originally filed as https://bugs.chromium.org/p/chromium/issues/detail?id=552455. The maintainers asked that it be re-filed with justification since work on it is not planned.

Why I think this is important:
* I wasted quite a bit of time trying to debug my sourcemaps because Chrome does not comply with the spec and gives no obvious error. I am sure that this has happened to other devs as well and will continue to happen.
* Our codebase still contains a workaround for this which makes our sourcemaps larger and more complex than they would be otherwise.
* Not knowing the Chrome codebase at all, it feels like this should be a relatively minor fix without broad implications. 
* Even a minor change to report the specific cause of failure would be a significant improvement; this should be a very inexpensive change.
 
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
@lushnikov, let's consider adding better error messaging for this?
Status: Archived (was: Assigned)
DevTools bug triage: closing low-priority bugs that don't have much demand.
@lushnikov I'm disappointed to see this be archived. It seems like it would be super easy to just add an error message rather than failing silently.
#3: ah, fair. CL for the warning is out: https://chromium-review.googlesource.com/c/chromium/src/+/1389119/
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/994b785a2ad888999bb53ce4c30f618c38c46f4c

commit 994b785a2ad888999bb53ce4c30f618c38c46f4c
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Fri Jan 11 02:08:16 2019

DevTools: emit warning if sourcemap contains "URL" field in its section

BUG= 793799 
R=dgozman

Change-Id: Ia294500a94cae59ead1c1600b90115c79e13a8e7
Reviewed-on: https://chromium-review.googlesource.com/c/1389119
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621867}
[modify] https://crrev.com/994b785a2ad888999bb53ce4c30f618c38c46f4c/third_party/blink/renderer/devtools/front_end/sdk/SourceMap.js
[add] https://crrev.com/994b785a2ad888999bb53ce4c30f618c38c46f4c/third_party/blink/web_tests/http/tests/devtools/resources/source-map-warning.html
[add] https://crrev.com/994b785a2ad888999bb53ce4c30f618c38c46f4c/third_party/blink/web_tests/http/tests/devtools/resources/source-map-warning.js
[add] https://crrev.com/994b785a2ad888999bb53ce4c30f618c38c46f4c/third_party/blink/web_tests/http/tests/devtools/resources/source-map-warning.map.json
[add] https://crrev.com/994b785a2ad888999bb53ce4c30f618c38c46f4c/third_party/blink/web_tests/http/tests/devtools/sourcemap-section-warning-expected.txt
[add] https://crrev.com/994b785a2ad888999bb53ce4c30f618c38c46f4c/third_party/blink/web_tests/http/tests/devtools/sourcemap-section-warning.js

Sign in to add a comment