New issue
Advanced search Search tips

Issue 793771 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Media Controls: Implement scrubbing behavior

Project Member Reported by beccahughes@chromium.org, Dec 11 2017

Issue description

Implement scrubbing behavior as per spec.
 
Cc: steimel@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a71acc87a9ff08dd997d7b81a19d11347974501

commit 2a71acc87a9ff08dd997d7b81a19d11347974501
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Dec 19 18:21:04 2017

Media Controls: Implement scrubbing behavior

Implement the new scrubbing behavior. This also moves scrubbing to using
Touch events on mobile as they provide a much smoother experience than
using Pointer events.

BUG= 793771 

Change-Id: I61a5658505b805baf6a9389bfb097350b3b0dbac
Reviewed-on: https://chromium-review.googlesource.com/824263
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525087}
[modify] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/LayoutTests/media/controls/modern/scrubbing-touch.html
[add] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/LayoutTests/media/controls/modern/scrubbing.html
[modify] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/Source/modules/media_controls/elements/MediaControlSliderElement.h
[modify] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
[modify] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.h
[modify] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElementTest.cpp
[modify] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
[modify] https://crrev.com/2a71acc87a9ff08dd997d7b81a19d11347974501/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls_timeline.css

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/320e9d6d68b6b347a5bb60ca0eeeab20b9cec9b1

commit 320e9d6d68b6b347a5bb60ca0eeeab20b9cec9b1
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Jan 18 02:31:43 2018

Mark virtual/modern-media-controls/media/controls/modern/scrubbing.html as Slow

According to the flakiness dashboard, most successful runs of the test
took 5~6 seconds which is borderline of timeout, and sometimes it also
flakily timed out.

Bug:  793771 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5856ae5be0dcea39d28e1ce25d810658b3048711
TBR: beccahughes@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/871846
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530020}
[modify] https://crrev.com/320e9d6d68b6b347a5bb60ca0eeeab20b9cec9b1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v175
[modify] https://crrev.com/320e9d6d68b6b347a5bb60ca0eeeab20b9cec9b1/third_party/WebKit/LayoutTests/SlowTests

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c9040c1e0e0d24d3c4a61d0c7057c51fa0bbc1a

commit 9c9040c1e0e0d24d3c4a61d0c7057c51fa0bbc1a
Author: Kevin McNee <mcnee@chromium.org>
Date: Wed Jun 06 20:02:06 2018

Mark virtual/new-remote-playback-pipeline/media/controls/modern/scrubbing.html slow

Other versions of media/controls/modern/scrubbing.html are marked slow,
but not virtual/new-remote-playback-pipeline/, causing this to flakily
time out.

Bug:  793771 ,  850116 
Change-Id: I3a45716ebd797f781573b2d5d86dfa58b213b271
Reviewed-on: https://chromium-review.googlesource.com/1089384
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565012}
[modify] https://crrev.com/9c9040c1e0e0d24d3c4a61d0c7057c51fa0bbc1a/third_party/WebKit/LayoutTests/SlowTests

Sign in to add a comment