insertDTMF does not throw InvalidCharacterError |
||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/62.0.3202.94 Chrome/62.0.3202.94 Safari/537.36 Steps to reproduce the problem: 1. go to https://webrtc.github.io/samples/src/content/peerconnection/dtmf/ 2. click "call" 3. change tones to "123 abc" What is the expected behavior? http://w3c.github.io/webrtc-pc/#dom-rtcdtmfsender-insertdtmf throws InvalidCharacterError What went wrong? the receiver receivers "123abc". Chrome (or webrtc.org) seems to silently ignore the invalid characters. Did this work before? N/A Does this work in other browsers? Yes Chrome version: 62.0.3202.94 Channel: n/a OS Version: Flash Version:
,
Mar 16 2018
Has this been fixed?
In 67.0.3372.0, I see a script exception
main.js:227 Uncaught DOMException: Failed to execute 'insertDTMF' on 'RTCDTMFSender': Illegal characers in InsertDTMF tone argument
at sendTones (https://webrtc.github.io/samples/src/content/peerconnection/dtmf/js/main.js:227:16)
at HTMLButtonElement.handleSendTonesClick (https://webrtc.github.io/samples/src/content/peerconnection/dtmf/js/main.js:232:3)
,
Mar 16 2018
Note, #3 reveals that there's a typo in our error message. "Characters" is misspelled as "characers" https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp?l=128&rcl=2348b44d2a5ba4e78f21bdd8a67d89e718f02ef6
,
Mar 16 2018
hta@ might know, he made dtmf changes recently. Can you cc him please? And is also to blame for the typo it seems :-p
,
Mar 16 2018
Looks like the overall bug was fixed in February by https://chromium.googlesource.com/chromium/src/+/f1bbe6226e8009c584a019ed943e1c8535197068, which also introduced the typo.
,
Mar 16 2018
,
Mar 16 2018
Yes, I added stricter charset checking. the spec says that space is not allowed, so I disallowed it. Marking as fixed; I'll get to the misspelling.
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ab8bfcc117475ce646bb6ea3f05219d4e0f0e05 commit 1ab8bfcc117475ce646bb6ea3f05219d4e0f0e05 Author: Harald Alvestrand <hta@chromium.org> Date: Mon Mar 19 15:47:11 2018 Fix 3 misspellings of "characters" Bug: 793766 Change-Id: Ie82fc929ae81c3894f10fa0efa0867c21258f392 Reviewed-on: https://chromium-review.googlesource.com/966842 Reviewed-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#544045} [modify] https://crrev.com/1ab8bfcc117475ce646bb6ea3f05219d4e0f0e05/base/i18n/file_util_icu_unittest.cc [modify] https://crrev.com/1ab8bfcc117475ce646bb6ea3f05219d4e0f0e05/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp [modify] https://crrev.com/1ab8bfcc117475ce646bb6ea3f05219d4e0f0e05/third_party/WebKit/Source/platform/weborigin/KURL.h |
||||
►
Sign in to add a comment |
||||
Comment 1 by guidou@chromium.org
, Dec 11 2017Owner: hbos@chromium.org
Status: Assigned (was: Unconfirmed)