New issue
Advanced search Search tips

Issue 793765 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

syntax error in /chromium/chrome/test/chromedriver/js/dispatch_touch_event.js

Reported by finot.st...@gmail.com, Dec 11 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce the problem:
N/A

What is the expected behavior?

What went wrong?
In "function dispatchTouchEvent(x, y, type)" there is a syntax error on:
 "var inputDeviceCapabilities =
    new InputDeviceCapabilities({fireTouchEvents: true});".

It is missing a "s" at the end of "fire" of "fireTouchEvents". It should be "firesTouchEvents". I think it can cause issues when using Hammer API.

Did this work before? No 

Chrome version: 62.0.3202.94  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 
Components: -Blink Blink>Input
Owner: dtapu...@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5df33b20da06c2743999b998eb982d612ccaa350

commit 5df33b20da06c2743999b998eb982d612ccaa350
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Dec 11 15:28:40 2017

Fix incorrect InputDeviceCapabilities property.

A property was misspelled in a synthetic injection test correct its name.

BUG= 793765 

Change-Id: Iaa41840b0fe27d01b2729d1f46c57d7b6f7c4ac4
Reviewed-on: https://chromium-review.googlesource.com/819490
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523100}
[modify] https://crrev.com/5df33b20da06c2743999b998eb982d612ccaa350/chrome/test/chromedriver/js/dispatch_touch_event.js

Status: Fixed (was: Assigned)

Sign in to add a comment