New issue
Advanced search Search tips

Issue 793759 link

Starred by 1 user
Status: Archived
Owner:
jclinton@chromium.org
Closed: Dec 2017
Cc:
akes...@chromium.org
chirantan@chromium.org
derat@chromium.org
vapier@chromium.org
pmalani@chromium.org
jclinton@chromium.org
sjg@chromium.org
shapiroc@chromium.org
nya@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromeos-base/power_manager should not depend on platform2 files outside of power_manager/

Project Member Reported by nya@chromium.org, Dec 11 2017 
chromeos-base/power_manager includes following platform2 files outside of power_manager/ to compile:

- chromeos-config/libcros_config/cros_config.h
- chromeos-config/libcros_config/cros_config_interface.h
- chromeos-config/libcros_config/fake_cros_config.h

We should include the headers installed by corresponding packages instead.

Comment 1 by derat@chromium.org, Dec 11 2017

Cc: sjg@chromium.org jclinton@chromium.org
Components: OS>Kernel>Power
Labels: -Pri-3 Pri-2
Owner: la...@chromium.org
Status: Assigned (was: Untriaged)
(The issue here is that the headers in platform2/ may not match the ones that were used to build the cros_config library, depending on when the developer has synced, cros_workon status, etc.)

Comment 2 by jclinton@chromium.org, Dec 18 2017

Cc: shapiroc@chromium.org

Comment 3 by jclinton@chromium.org, Dec 18 2017

Owner: jclinton@chromium.org
Lann is on leave; taking this.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9454c2a97ee5377b2ddeccaa57c4ac6cd033dfd1

commit 9454c2a97ee5377b2ddeccaa57c4ac6cd033dfd1
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Wed Dec 20 08:34:03 2017

chromeos-config-tools: Install headers

BUG= chromium:793759 
TEST=cros_workon; emerge; 'equery files' to confirm installed

Change-Id: Ia0aa8f9e682b15953e21fabb395e279d3db89171
Reviewed-on: https://chromium-review.googlesource.com/834793
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/9454c2a97ee5377b2ddeccaa57c4ac6cd033dfd1/chromeos-base/chromeos-config-tools/chromeos-config-tools-9999.ebuild
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/42849d3f6c8dac913e05f9e5dcb9b39eeb3e7031

commit 42849d3f6c8dac913e05f9e5dcb9b39eeb3e7031
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Wed Dec 20 08:34:03 2017

power: Use sysroot-installed cros_config headers

BUG= chromium:793759 
TEST=cros_workon; FEATURES=test emerge power_manager
CQ-DEPEND=CL:834793

Change-Id: I26aa2deeb7d5cf81d161f78c7a494896063a2d92
Reviewed-on: https://chromium-review.googlesource.com/834755
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/42849d3f6c8dac913e05f9e5dcb9b39eeb3e7031/power_manager/common/prefs_unittest.cc
[modify] https://crrev.com/42849d3f6c8dac913e05f9e5dcb9b39eeb3e7031/power_manager/common/cros_config_prefs_source.h
[modify] https://crrev.com/42849d3f6c8dac913e05f9e5dcb9b39eeb3e7031/power_manager/common/prefs.cc

Comment 6 by jclinton@chromium.org, Dec 21 2017

Status: Fixed (was: Assigned)

Comment 7 by dchan@google.com, Jul 30

Status: Archived (was: Fixed)
►

Sign in to add a comment