Issue metadata
Sign in to add a comment
|
chromeos-base/chromeos-login should not depend on platform2 files outside of login_manager/ |
||||||||||||||||||||||||
Issue descriptionchromeos-base/chromeos-login includes following platform2 files outside of login_manager/ to compile: - chromeos-config/libcros_config/cros_config.h - chromeos-config/libcros_config/cros_config_interface.h - chromeos-config/libcros_config/fake_cros_config.h - libcontainer/libcontainer.h We should include the headers installed by corresponding packages instead.
,
Jan 2 2018
Ben, I think you ended up doing this?
,
Jan 2 2018
crrev.com/c/837181 installs the chromeos-config headers under /usr/include/chromeos. Does anything else need to change to get chromeos-login to pick those up?
,
Jan 2 2018
My guess is that it needs to change to <> instead of "" so that it picks up the files from the /usr/include directory
,
Feb 6 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by derat@chromium.org
, Dec 11 2017Labels: -Pri-3 Pri-2
Owner: sjg@chromium.org
Status: Assigned (was: Untriaged)