New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793754 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Regression: Chromevox focus is seen misplaced in OOBE screen

Project Member Reported by kebalaji@chromium.org, Dec 11 2017

Issue description

Chrome Version: 65.0.3287.0/10204.0.0 Kip,Daisy,Reks
OS:chrome OS

What steps will reproduce the problem?
(1)Recover build>> In OOBE screen, Enable Chromevox from Accessibility menu
(2)Keep tabbing until focus reaches Chromevox toggle button and observe

Expected: Chromevox focus should be seen on Chromevox toggle button
Actual: Instead, Chromevox focus is seen on Shutdown button

This is a Regression issue as same is working fine in 64.0.3282.14/10176.7.0 dev 

NOTE:1. Issue is seen in other overlays as well like Google OS terms page, 
        Connect to Network of OOBE screen etc., Attaching the screenshots.
     2. Issue is not seen on Linux and Windows.

@Dmazzoni: Please confirm the issue

 
ActualCFIssue.mp4
7.8 MB View Download
ExpectedCFIssue.mp4
5.0 MB View Download
Actual1.jpg
2.0 MB View Download
Actual2.jpg
1.6 MB View Download
Actual3.jpg
1.2 MB View Download
Owner: kebalaji@chromium.org
Unable to reproduce today. Can you check again?

Able to reproduce on  65.0.3287.0/10209.0.0 dev. Attaching the screencast.

Thanks!
793754.mp4
8.1 MB View Download
Owner: dmazz...@chromium.org
Able to reproduce the issue on 66.0.3327.0/10330.0.0 dev channel Kip, Daisy,Reks

Thanks!
Any update on this? 

It is marked as a beta blocker for 65, and the beta promotion date is only a week away.
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
I don't think it will block Beta, moving to RBS.
I can reproduce on 66, bisected to:

You are probably looking for a change made after 529959 (known good), but no later than 529989 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8..f1d9af002af9478cb193b775b9b5889455c67e51

Owner: dtseng@chromium.org
This is the culprit:

Use web-based hit testing for focus recovery
Bug:  800171 
Reviewed-on: https://chromium-review.googlesource.com/857878

David, unfortunately the focus recovery seems to be working as written here and it's definitely producing bad behavior. Essentially if you tab out of a web page and then tab back in, it "recovers" focus to the last place you were focused, rather than to the first element, which is what really does have focus.

I don't see an easy fix. I think we should maybe disable focus recovery to be safe until we have a better solution.



Fix for at least this case landing now:
https://chromium-review.googlesource.com/926221

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d59213885199140c69e377c95030d71a5aa9f436

commit d59213885199140c69e377c95030d71a5aa9f436
Author: David Tseng <dtseng@chromium.org>
Date: Tue Feb 20 18:05:58 2018

Exclude chrome urls from focus recovery

Bug:  793754 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia452a9c25fbd35b0ccc91ac6572e3e5c11dc8418
Reviewed-on: https://chromium-review.googlesource.com/926221
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537818}
[modify] https://crrev.com/d59213885199140c69e377c95030d71a5aa9f436/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Labels: Merge-Request-65
Status: Fixed (was: Assigned)
Project Member

Comment 11 by sheriffbot@chromium.org, Feb 20 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 21 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32430360c4f2fedebc4d9a8ffcf22b054927741f

commit 32430360c4f2fedebc4d9a8ffcf22b054927741f
Author: David Tseng <dtseng@chromium.org>
Date: Wed Feb 21 03:13:48 2018

Merge to m65: Exclude chrome urls from focus recovery

TBR=dtseng@chromium.org

Bug:  793754 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia452a9c25fbd35b0ccc91ac6572e3e5c11dc8418
Reviewed-on: https://chromium-review.googlesource.com/926221
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537818}
Reviewed-on: https://chromium-review.googlesource.com/927840
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#526}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/32430360c4f2fedebc4d9a8ffcf22b054927741f/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Sign in to add a comment