New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 793741 link

Starred by 1 user
Status: Verified
Owner:
█ reve...@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
█ elizabethchiu@chromium.org
ajha@chromium.org
█ reve...@chromium.org
█ brajkumar@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Discard photo tool tip is observed in video mode of changePicture overlay

Project Member Reported by rkalavakuntla@chromium.org, Dec 11 2017 
Chrome Version: 65.0.3287.0/10204.0.0 Kip,Daisy,Reks
OS:chrome OS

What steps will reproduce the problem?
(1)Sign into user ->Launch chrome,open chrome://settings/changePicture 
(2)click to Capture video, after capturing the video hover the mouse on discard button and Observe the tool tip

Actual: In video mode, Discard photo tool tip is seen
Expected :Instead,it should be as Discard video

This is a Non-Regression as it is seen from 63.0.3230.0/9997.0.0 dev channel Daisy

Note:Issue is not seen in Linux,Windows OS

@stevenjb: Please confirm the issue
actualtooltip.webm
1.1 MB View Download

Comment 1 by reve...@chromium.org, Dec 11 2017

Owner: elizabethchiu@chromium.org
There's no easy way to know if it's a photo or video today. This is media from camera of file so if we want to improve this today we'd need to use some more generic name such as "Discard media" or "Discard photo or video". elizabethchiu@, wdyt?

Comment 2 by elizabethchiu@chromium.org, Dec 11 2017 

"Discard photo or video"is better in this case. 

If we can detect which button user tab on ("camera" or "video recorder"), it would be best if we can show "delete photo" or "delete video"correspondingly.

Comment 3 by reve...@chromium.org, Dec 11 2017

Cc: elizabethchiu@chromium.org
Owner: reve...@chromium.org
Thanks. I'll update it to "Discard photo or video" for now and file a bug about improving it by detecting if current profile image is a video or a photo.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bedaaa53f5bf8326ae2fb7ea29b2302e8e7842a2

commit bedaaa53f5bf8326ae2fb7ea29b2302e8e7842a2
Author: David Reveman <reveman@chromium.org>
Date: Mon Dec 11 21:51:11 2017

Change Picture: Improve discard button label.

The image that will be discarded can be either a photo or a video.

Bug:  793741 
Change-Id: Ie26ebc793b945730142e93cfb0bd02aa20dabfd9
Reviewed-on: https://chromium-review.googlesource.com/820414
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523220}
[modify] https://crrev.com/bedaaa53f5bf8326ae2fb7ea29b2302e8e7842a2/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/bedaaa53f5bf8326ae2fb7ea29b2302e8e7842a2/chrome/app/settings_strings.grdp

Comment 5 by reve...@chromium.org, Dec 11 2017

Status: Fixed (was: Assigned)

Comment 6 by sdantul...@chromium.org, Jan 5 2018

Status: Verified (was: Fixed)
10279.0.0, 65.0.3311.0
►

Sign in to add a comment