New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 793735 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Jan 2018
Cc:
qyears...@chromium.org
mar...@chromium.org
█ emso@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task



Sign in to add a comment

Separate analyzers and isolators in the config.

Project Member Reported by emso@chromium.org, Dec 11 2017 
This separation was in place earlier in the design but was removed in favor of simplicity. However, the simplicity is obscuring. Isolators are different and it is weird to call them analyzers. Both analyzers and isolators are function, but analyzers must only return results.

Progress reporting should be updated as part of this change. For instance, it does not makes sense to report results for isolators. This distinction becomes more clear with this change.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/069fd6087cfeab9ec27408a748deac7cf95ded6a

commit 069fd6087cfeab9ec27408a748deac7cf95ded6a
Author: Emma <emso@chromium.org>
Date: Thu Dec 14 09:43:00 2017

Introduces functions into the Tricium config.

Bug:793735
Change-Id: I8fa54ebcb844338f68644293a9af0d7c7f872670
Reviewed-on: https://chromium-review.googlesource.com/822418
Commit-Queue: Emma Söderberg <emso@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/appengine/devcfg/projects/infra/tricium-dev.cfg
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/api/v1/tricium.pb.go
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/appengine/common/config/validate.go
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/appengine/common/isolate.go
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/appengine/devcfg/services/tricium-dev/service.cfg
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/api/v1/config.proto
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/appengine/common/config/generate_test.go
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/api/v1/pb.discovery.go
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/appengine/common/config/validate_test.go
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/api/v1/config.pb.go
[add] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/api/v1/function.proto
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/appengine/devcfg/projects/playground-gerrit-tricium/tricium-dev.cfg
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/appengine/launcher/rpc_launch_test.go
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/appengine/common/config/generate.go
[add] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/api/v1/function.pb.go
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/api/v1/platform.pb.go
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/api/v1/config_helpers.go
[modify] https://crrev.com/069fd6087cfeab9ec27408a748deac7cf95ded6a/go/src/infra/tricium/api/v1/config_helpers_test.go
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/05413ac8fc906b53d248193b299940a6e7a97829

commit 05413ac8fc906b53d248193b299940a6e7a97829
Author: Emma Soederberg <emso@google.com>
Date: Thu Dec 14 10:21:15 2017
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2017

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/playground/gerrit-tricium/+/593118723f6229883c2a7b0bc083a3d10659469a

commit 593118723f6229883c2a7b0bc083a3d10659469a
Author: Emma <emso@chromium.org>
Date: Thu Dec 14 10:19:38 2017

Renames analyzers to functions in the Tricium config.

Also adds the code review config which for some reason was not already added.

Bug:793735
Change-Id: Ia0fda15ce3ec0c6d5a0309afd4de8600aec050d9

[modify] https://crrev.com/593118723f6229883c2a7b0bc083a3d10659469a/tricium-dev.cfg
[add] https://crrev.com/593118723f6229883c2a7b0bc083a3d10659469a/codereview.settings
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/18ebe3bde7e7b4e2756e4a38d19e23c6473bc43b

commit 18ebe3bde7e7b4e2756e4a38d19e23c6473bc43b
Author: Emma Soederberg <emso@google.com>
Date: Thu Dec 14 16:18:47 2017
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 15 2017

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/playground/gerrit-tricium/demo/+/29f645adfb1f8d21621a999a0f73026ec39a6bca

commit 29f645adfb1f8d21621a999a0f73026ec39a6bca
Author: Emma <emso@google.com>
Date: Fri Dec 15 12:42:22 2017

Converts tricium-prod config to use functions

Bug:793735
Change-Id: I0d9e6b3e60baf3b03537713dd47e3971a7d2b058
[modify] https://crrev.com/29f645adfb1f8d21621a999a0f73026ec39a6bca/tricium-prod.cfg
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/0b61403aae09e811add50a4bb58f3ab42e75ff4b

commit 0b61403aae09e811add50a4bb58f3ab42e75ff4b
Author: Emma Soederberg <emso@google.com>
Date: Fri Dec 15 12:45:43 2017

Comment 7 by emso@chromium.org, Dec 18 2017

Status: Verified (was: Assigned)

Comment 8 by qyears...@chromium.org, Jan 11 2018 

I believe there are a couple more follow-up tasks to make everything consistent after changing to use the term "functions": 

 - track.AnalyzerRun and track.AnalyzerRunResult could be called FunctionRun and FunctionRunResult, and they could have the function type included as a property.
 - A Worker may execute either an Isolator or Analyzer, so track.WorkerRunResult could potentially also include the function type that was run.
 - the analyzers/ directory in the infra repo and in chrome-infra-packages could be renamed to functions.
 - The Tricium plugin needs to be updated

I'm not sure if it's worth it to file a new issue for these -- OK to reuse this issue number?

Comment 9 by emso@chromium.org, Jan 12 2018

Owner: qyears...@chromium.org
Status: Assigned (was: Verified)
Overall sounds good. 

Regarding WorkerRun, the type of the function will be available in the FunctionRun run parent (provided bullet one). If not included in the tracking, the type will be available in the config, but it may make sense to store it in the tracking objects to not have to look it up again.

You sent a couple of changes already so I'll move this over to you. Feel free to send back :)
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2

commit ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Jan 12 18:17:33 2018

Move tricium/analyzers/ to tricium/functions/

Bug:  793735 
Change-Id: I8969e6fba20903332c18b7f716f85f89da82c70f
Reviewed-on: https://chromium-review.googlesource.com/862619
Reviewed-by: Emma Söderberg <emso@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/spacey/test/README.md
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/hello/test/tricium/data/files.json
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/hello/cipd.yaml
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/hello/hello.go
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/spacey/test/src/Hello.java
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/spacey/cipd.yaml
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/git-file-isolator/test/tricium/data/git_file_details.json
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/hello/test/README.md
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/git-file-isolator/README.md
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/git-file-isolator/.gitignore
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/hello/test/src/src.infra_testing
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/spacey/spacey.go
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/spacey/spacey.infra_testing
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/spacey/.gitignore
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/spacey/spacey_test.go
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/git-file-isolator/cipd.yaml
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/hello/hello.infra_testing
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/spacey/test/src/.gitignore
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/hello/.gitignore
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/git-file-isolator/isolator.go
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/hello/test/src/main.go
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/hello/README.md
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/spacey/test/tricium/data/files.json
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/git-file-isolator/git-file-isolator.infra_testing
[rename] https://crrev.com/ec3390c68b9b582cfee5d13e5f94f7f535dfb2b2/go/src/infra/tricium/functions/spacey/README.md
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6a21e50cd3cc1416d71133d5338536cbad1d0071

commit 6a21e50cd3cc1416d71133d5338536cbad1d0071
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Fri Jan 12 18:44:23 2018

Rename AnalyzerProgress to FunctionProgress

ProgressResponse includes results for both isolators and analyzers.

We still want to include both types of function, but will likely
want to differentiate them in the Gerrit plugin UI.

This is one change to switch to using the new terminology and
concept of functions including isolators and analyzers.

Bug:  793735 , 799838
Change-Id: I12b68b4c2265becf0a1ae60f269b7541c13ef631
Reviewed-on: https://chromium-review.googlesource.com/861097
Reviewed-by: Emma Söderberg <emso@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/tricium.pb.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/data.pb.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/data.proto
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/config.pb.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/platform.proto
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/pb.discovery.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/appengine/frontend/rpc_progress.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/tricium.proto
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/api/v1/platform.pb.go
[modify] https://crrev.com/6a21e50cd3cc1416d71133d5338536cbad1d0071/go/src/infra/tricium/appengine/frontend/rpc_progress_test.go
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/136724ac878ab11534c0bd173b6c618d94d1f751

commit 136724ac878ab11534c0bd173b6c618d94d1f751
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Wed Jan 17 23:44:53 2018

Rename AnalyzerRun to FunctionRun

In this CL:
 - Rename track.AnalyzerRun to track.FunctionRun
 - Rename track.AnalyzerRunResult to track.FunctionRunResult

This change doesn't affect the API, but does affect
the datastore schema.

I plan to use the datastore manager to remove AnalyzerRun
and AnalyzerRunResult entities from the datastore after
this change.

This is expected to cause progress requests
for past runs to return empty results.

Bug:  793735 
Change-Id: I3e4e07ec5456b9d142b685afc5acbe0fb222eb26
Reviewed-on: https://chromium-review.googlesource.com/865957
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/common/track/track.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/api/admin/v1/pb.discovery.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/tracker/rpc_worker_launched_test.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/tracker/rpc_worker_done_test.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/gerrit/rpc_report_completed.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/frontend/rpc_results_test.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/frontend/rpc_report_test.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/gerrit/rpc_report_results_test.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/gerrit/rpc_report_completed_test.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/tracker/rpc_worker_launched.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/frontend/rpc_progress_test.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/api/admin/v1/workflow.proto
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/gerrit/rpc_report_results.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/common/config/validate_test.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/common/track/track_test.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/frontend/handlers.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/tracker/rpc_worker_done.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/frontend/rpc_progress.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/api/admin/v1/workflow.pb.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/frontend/rpc_feedback_test.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/tracker/rpc_workflow_launched_test.go
[modify] https://crrev.com/136724ac878ab11534c0bd173b6c618d94d1f751/go/src/infra/tricium/appengine/tracker/rpc_workflow_launched.go
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a28040095533a9b1dca5038f2ffde88057cdf1db

commit a28040095533a9b1dca5038f2ffde88057cdf1db
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Jan 18 17:14:36 2018

Tricium: Update function CIPD package upload locations

This change doesn't actually change where functions are
retrieved from for tricium-dev or tricium-prod; that is
determined by service configs. This change should be
followed by changes in the service configs.

Note: I have already uploaded CIPD packages for these
functions to their new locations.

Bug:  793735 
Change-Id: I2e614761ea829acd11e3cd885fefff9d039d49e1
Reviewed-on: https://chromium-review.googlesource.com/872190
Reviewed-by: Emma Söderberg <emso@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/a28040095533a9b1dca5038f2ffde88057cdf1db/go/src/infra/tricium/functions/git-file-isolator/README.md
[modify] https://crrev.com/a28040095533a9b1dca5038f2ffde88057cdf1db/go/src/infra/tricium/functions/spacey/README.md
[modify] https://crrev.com/a28040095533a9b1dca5038f2ffde88057cdf1db/go/src/infra/tricium/appengine/devcfg/services/tricium-dev/service.cfg
[modify] https://crrev.com/a28040095533a9b1dca5038f2ffde88057cdf1db/go/src/infra/tricium/functions/git-file-isolator/cipd.yaml
[modify] https://crrev.com/a28040095533a9b1dca5038f2ffde88057cdf1db/go/src/infra/tricium/functions/spacey/cipd.yaml
[modify] https://crrev.com/a28040095533a9b1dca5038f2ffde88057cdf1db/go/src/infra/tricium/functions/hello/cipd.yaml
[modify] https://crrev.com/a28040095533a9b1dca5038f2ffde88057cdf1db/go/src/infra/tricium/functions/hello/README.md
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/47f30260db37380176d3dd09356bdf8f2fdff8f8

commit 47f30260db37380176d3dd09356bdf8f2fdff8f8
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Jan 18 18:54:19 2018
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/10d0d8787f2a5d8323896436227c3335b9a12f20

commit 10d0d8787f2a5d8323896436227c3335b9a12f20
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Jan 18 19:05:57 2018

Rename model fields Analyzer(s) to Functions(s)

This is a follow-up to https://crrev.com/c/865957 and was
originally part of that change. Like that change, this
is a breaking change, meaning that requests which involve
looking up functions or getting the function name from
a worker run, including Progress requests, will not
work for past analyze requests.

Bug:  793735 
Change-Id: Iafaa3e737506d1a2ca967c7b8e4f97673b6c4578
Reviewed-on: https://chromium-review.googlesource.com/872116
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Emma Söderberg <emso@chromium.org>

[modify] https://crrev.com/10d0d8787f2a5d8323896436227c3335b9a12f20/go/src/infra/tricium/appengine/common/track/track.go
[modify] https://crrev.com/10d0d8787f2a5d8323896436227c3335b9a12f20/go/src/infra/tricium/appengine/frontend/rpc_progress_test.go
[modify] https://crrev.com/10d0d8787f2a5d8323896436227c3335b9a12f20/go/src/infra/tricium/appengine/frontend/rpc_progress.go
[modify] https://crrev.com/10d0d8787f2a5d8323896436227c3335b9a12f20/go/src/infra/tricium/appengine/frontend/rpc_project_progress_test.go
[modify] https://crrev.com/10d0d8787f2a5d8323896436227c3335b9a12f20/go/src/infra/tricium/appengine/tracker/rpc_workflow_launched_test.go
[modify] https://crrev.com/10d0d8787f2a5d8323896436227c3335b9a12f20/go/src/infra/tricium/appengine/tracker/rpc_worker_done.go
[modify] https://crrev.com/10d0d8787f2a5d8323896436227c3335b9a12f20/go/src/infra/tricium/appengine/tracker/rpc_workflow_launched.go
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 25 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/66991a34348d83516ff22fe772f91183e926b9a8

commit 66991a34348d83516ff22fe772f91183e926b9a8
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Jan 25 22:36:29 2018

Comment 17 by qyears...@chromium.org, Jan 30 2018

Status: Fixed (was: Assigned)
Everything from #8 is now done, with the exception of adding function type to track.WorkerRunResult. This is not strictly related, and may not be necessary, so I'll close this now.
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/66acb1cd1f26721fe7081e91e6c3220723113f5f

commit 66acb1cd1f26721fe7081e91e6c3220723113f5f
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Tue Feb 06 16:29:15 2018

Update path in example input in GitFileIsolator test

This is related to the change to rename
"analyzers" to "functions".

This doesn't change any behavior yet.

Bug:  793735 
Change-Id: Ia4d63eacec15e4829cbe3e7c8aa0aad186949417
Reviewed-on: https://chromium-review.googlesource.com/894724
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/66acb1cd1f26721fe7081e91e6c3220723113f5f/go/src/infra/tricium/functions/git-file-isolator/test/tricium/data/git_file_details.json
►

Sign in to add a comment