New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793722 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake analyzer - Move heuristic results to services

Project Member Reported by lijeffrey@chromium.org, Dec 11 2017

Issue description

heuristic analysis should be in services odules instead of pipelines
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/57920812bc6c83a842891fb291f4f7f8c344fea7

commit 57920812bc6c83a842891fb291f4f7f8c344fea7
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Wed Dec 13 22:17:37 2017

[Findit] Flake Analyzer - Moving heuristic analysis to services

GetTestLocationPipeline and IdentifySuspectedRevisionsPipeline are both
really just function calls, putting them each in separate pipeline was
slightly overkill. To reduce the number of pipelines/subpipelines needed
for flake analyzer, these can be turned into isolated function calls.

This change also turns the returned test location dictionary into a
structured object as part of refactoring efforts.

Bug:  793722 
Change-Id: Ia0b4999f3f112a0a06e07077ab33b7e85c378e40
Reviewed-on: https://chromium-review.googlesource.com/818609
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/waterfall/flake/initialize_flake_try_job_pipeline.py
[rename] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/services/flake_failure/heuristic_analysis.py
[delete] https://crrev.com/1e0e56837fa67c3c9e3c4bd45d800cf2bb79a8fd/appengine/findit/waterfall/flake/test/identify_suspected_revisions_pipeline_test.py
[modify] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py
[modify] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py
[modify] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/waterfall/flake/test/finish_build_analysis_pipeline_test.py
[delete] https://crrev.com/1e0e56837fa67c3c9e3c4bd45d800cf2bb79a8fd/appengine/findit/waterfall/flake/test/get_test_location_pipeline_test.py
[add] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/dto/__init__.py
[modify] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/waterfall/flake/flake_constants.py
[modify] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py
[delete] https://crrev.com/1e0e56837fa67c3c9e3c4bd45d800cf2bb79a8fd/appengine/findit/waterfall/flake/get_test_location_pipeline.py
[add] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/dto/test_location.py
[modify] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/waterfall/flake/finish_build_analysis_pipeline.py
[rename] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/services/flake_failure/test/heuristic_analysis_test.py
[modify] https://crrev.com/57920812bc6c83a842891fb291f4f7f8c344fea7/appengine/findit/waterfall/flake/test/recursive_flake_try_job_pipeline_test.py
[delete] https://crrev.com/1e0e56837fa67c3c9e3c4bd45d800cf2bb79a8fd/appengine/findit/waterfall/flake/identify_suspected_revisions_pipeline.py

Status: Fixed (was: Untriaged)

Sign in to add a comment