"UBSan vptr Release" build is broken |
|||
Issue descriptionThe build is broken since: https://ci.chromium.org/buildbot/chromium.lkgr/UBSan%20vptr%20Release/10109 It seems that https://chromium.googlesource.com/chromium/src/+/dcd2ad6518531c90ad3de404c52b369f33afe42e is the culprit
,
Dec 11 2017
Fix out for review https://chromium-review.googlesource.com/c/chromium/src/+/819978 Surprised the bots didn't catch this. My non-proprietary build compiles fine, so something about the ubsan flags surfaced it.
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/561193ab845c0eb9457ce7104b3b2f41565269d7 commit 561193ab845c0eb9457ce7104b3b2f41565269d7 Author: Chris Cunningham <chcunningham@chromium.org> Date: Mon Dec 11 22:56:06 2017 Include bitstream converters to fix UBSan vptr error The VideoSampleEntry box includes a scoped_refptr<BitstreamConverter> regardless always, but we were only building the BitstreamConverter cc/h files when proprietary_codecs=true. This CL includes the BitstreamConverter interface defintion in all builds. Proprietary bitsream conversion logic (e.g. AVCBitstreamConvter) is still only included if proprietary_codecs = true. BUG: 793702 Change-Id: I8720b6547ca2e0af47d64ae594e86850da0e84b5 Reviewed-on: https://chromium-review.googlesource.com/819978 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#523242} [modify] https://crrev.com/561193ab845c0eb9457ce7104b3b2f41565269d7/media/formats/BUILD.gn
,
Dec 11 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dalecur...@chromium.org
, Dec 11 2017