New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793667 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[OffscreenCanvas] Crash calling gl.createQuery()

Reported by a...@scirra.com, Dec 10 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3290.0 Safari/537.36

Steps to reproduce the problem:
1. Enable experimental canvas features in Canary so OffscreenCanvas is enabled
2. Visit https://www.scirra.com/labs/bugs/offscreencanvascrash - this page simply creates a WebGL 2 context and calls gl.createQuery()

What is the expected behavior?
Call to succeed

What went wrong?
Tab crashes with "Aw snap!"

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 65.0.3290.0  Channel: canary
OS Version: 10.0
Flash Version: 

It looks like it also reproduces without using a worker, i.e. calling createQuery() in the main document, but our use case involves calling from a worker.
 
Labels: Needs-Triage-M65
Labels: Needs-Bisect

Comment 3 by junov@chromium.org, Dec 12 2017

Owner: junov@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: sc00335...@techmahindra.com junov@chromium.org
Labels: -Type-Bug -Pri-2 -Needs-Bisect hasbisect-per-revision Triaged-ET M-65 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: xidac...@chromium.org
Able to reproduce this issue on reported version 65.0.3290.0 and on latest canary 65.0.3292.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.1 with steps mentioned in comment#0.

Bisect Info:
=========
Good Build:57.0.2926.0
Bad Build:  57.0.2928.0 

You are probably looking for a change made after 433720 (known good), but no later than 433721 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/08fa53494a55ea4cf7ca1561cf0f5ce3c37c7bfd..336743c75471ed1036037c0c423a78b4ad41fe3f

Review-Url: https://codereview.chromium.org/2509193002

Suspecting same from changelog.

@xidachen: Please confirm the issue and help in re-assigning if it is not related to your change.

Thanks!

Comment 5 by junov@chromium.org, Dec 13 2017

Owner: junov@chromium.org
I'll take this issue since xidachen@ no longer works on this.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00909018c2f1c97c00827d0e7d747712b3ac4afd

commit 00909018c2f1c97c00827d0e7d747712b3ac4afd
Author: Justin Novosad <junov@chromium.org>
Date: Thu Dec 14 15:54:40 2017

Fix crash when creating a webgl query with OffscreenCanvas

BUG= 793667 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifc75e2d1545346cf618a6a2303dc659369040674
Reviewed-on: https://chromium-review.googlesource.com/824983
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524076}
[add] https://crrev.com/00909018c2f1c97c00827d0e7d747712b3ac4afd/third_party/WebKit/LayoutTests/fast/canvas/webgl/create-query-crash-expected.html
[add] https://crrev.com/00909018c2f1c97c00827d0e7d747712b3ac4afd/third_party/WebKit/LayoutTests/fast/canvas/webgl/create-query-crash.html
[modify] https://crrev.com/00909018c2f1c97c00827d0e7d747712b3ac4afd/third_party/WebKit/Source/modules/webgl/WebGLQuery.cpp

Comment 7 by junov@chromium.org, Dec 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment