New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793612 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

guado_labstation canary is red

Reported by jrbarnette@chromium.org, Dec 9 2017

Issue description

The guado_labstation canary is red, and has been since
the R65-10179.0.0 build:
    https://uberchromegw.corp.google.com/i/chromeos/builders/guado_labstation-release/builds/1717

The builder seems to be producing images, and the failure
is in the TestSimpleChromeWorkflow stage, so the problem may
or may not be critical.

 
Cc: dgarr...@chromium.org dtor@chromium.org deanliao@chromium.org ecgh@chromium.org
Labels: -Pri-3 Pri-1
Owner: deanliao@chromium.org
Status: Assigned (was: Untriaged)
Escalating.  Looking at the history, the TestSimpleChromeWorkflow
failures were superseded by BuildPackages failures on 12/5.

We need this builder to be reliably green so that we can reliably
update servo on Servo V4 labstation hosts.

The relevant build error seems to be this:
    emerge: there are no ebuilds to satisfy "sys-process/criu[selinux=]" for /build/guado_labstation/.

This looks like it needs product expertise; passing to the non-PST
sheriff for initial triage/assignment.
The BuildPackages error is starting from #1726. Looking at it.
Owner: chirantan@chromium.org
Chirantan, it could be probably your CL to make guado_labstation build_package failed. Please take a look
Should be fixed by https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/832674 but it sounds like we need a labstation bot on the CQ.
What made labstation different enough to require the change?

> What made labstation different enough to require the change?

When I landed the lxc uprev, I had to mask the newer versions in the project-moblab overlay because the moblab code depended on the older version of lxc.

project-labstation doesn't inherit from the project-moblab overlay, which is why it didn't get the mask and tried to build the newer version of lxc.
> [ ... ] and tried to build the newer version of lxc.

How/why does the newer version of lxc work on other boards, but not
guado_labstation?

AFAIK there are only 2 things that depend on lxc:

* moblab and its variants
* project-termina

The issue with moblab specifically is that it uses lxc-clone, which was replaced in newer versions by lxc-copy.  This is relatively straightforward to fix: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/794876

The other issue is that newer versions of lxc depend on criu for snapshotting and restoring process trees, which I believe is functionality that moblab needs.  Unfortunately, criu fails to cross-compile, which is why it isn't available in our tree today.  project-termina deals with this issue by marking it as a provided package since termina doesn't actually use the features it provides.

Since I know very little about moblab and what features of criu it uses / how easy they would be to replace, I left it to the people who actually work on moblab to deal with that issue if and when they decide to update the version of lxc they use.

Looking more closely I see that moblab and labstation don't inherit from each other but they do inherit from mobbase.  Would it make more sense to put this change in that overlay so that all the moblab variants get it?
> Looking more closely I see that moblab and labstation
> don't inherit from each other but they do inherit from mobbase.
> Would it make more sense to put this change in that overlay so
> that all the moblab variants get it?

That would likely help, yes.

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/261383ca5a8c268ebbb415eb64cf7ff69fc10004

commit 261383ca5a8c268ebbb415eb64cf7ff69fc10004
Author: Chirantan Ekbote <chirantan@chromium.org>
Date: Tue Dec 19 06:55:04 2017

project-labstation: Mask newer lxc versions

Mask newer versions of lxc because they break labstation and copy the
old version of lxc into the project's overlay.

BUG=chromium:793612
TEST=cros tryjob guado_labstation-release

Change-Id: I1ef7c0c6507cc42720c7ecb69886baa10774dc84
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/832674
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/261383ca5a8c268ebbb415eb64cf7ff69fc10004/project-labstation/app-emulation/lxc/Manifest
[add] https://crrev.com/261383ca5a8c268ebbb415eb64cf7ff69fc10004/project-labstation/profiles/base/eapi
[add] https://crrev.com/261383ca5a8c268ebbb415eb64cf7ff69fc10004/project-labstation/app-emulation/lxc/metadata.xml
[add] https://crrev.com/261383ca5a8c268ebbb415eb64cf7ff69fc10004/project-labstation/app-emulation/lxc/files/lxc-1.0.6-bash-completion.patch
[add] https://crrev.com/261383ca5a8c268ebbb415eb64cf7ff69fc10004/project-labstation/profiles/base/package.mask
[add] https://crrev.com/261383ca5a8c268ebbb415eb64cf7ff69fc10004/project-labstation/app-emulation/lxc/files/lxc.initd.2
[add] https://crrev.com/261383ca5a8c268ebbb415eb64cf7ff69fc10004/project-labstation/app-emulation/lxc/files/lxc.initd.3
[add] https://crrev.com/261383ca5a8c268ebbb415eb64cf7ff69fc10004/project-labstation/app-emulation/lxc/files/lxc_at.service
[add] https://crrev.com/261383ca5a8c268ebbb415eb64cf7ff69fc10004/project-labstation/app-emulation/lxc/lxc-1.0.7.ebuild

Sign in to add a comment