No space between picture and divider line in new context menu |
||||||||
Issue descriptionSteps to reproduce the problem: 1. www.meteo.pl 2. open context menu for picture like in screenshot What is the expected behavior? At least one pixel space between picture and divider line What went wrong? Picture doesn't have attributes, no text is displayed and we don't see separator pixels Did this work before? No Chrome version: 65.0.3288.3 Channel: canary OS Version: 7 Flash Version:
,
Dec 11 2017
@marcin: Could you please confirm is this a feature request related to New context menu? Thanks!!
,
Dec 11 2017
My knowledge and Google experience allows for easy classifying it as bug... from the second hand I don't have access to all specs which you can probably read. Please try to search answer there, if not possible, please try to classify it with Google team.
,
Dec 11 2017
Thank you for providing more feedback. Adding requester "sandeepkumars@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 12 2017
This issue looks to be related to New Context Menu UI, which is introduced recently in M64, CC'ing @ltian who is recently worked on New Context Menu UI related issue. @ltian: Could you please take a look at this or help in assigning this issue to correct owner.
,
Dec 12 2017
@danielpark is the person who implements displaying this image. @danielpark: could you take a look of this issue?
,
Dec 13 2017
,
Jan 29 2018
danielpark@ -- Gentle ping to look into this issue. Thanks!
,
Jan 29 2018
looking.
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28ec2ab2f5f3cf467e8987fbc7d6f8e883ba4c3b commit 28ec2ab2f5f3cf467e8987fbc7d6f8e883ba4c3b Author: Daniel Park <danielpark@chromium.org> Date: Wed Jan 31 21:30:09 2018 [Custom Context Menu] Adds empty space below image >Adds new placeholder view and sets to visible if the selected image has no header text (i.e. ads) >Updates context menu test to account for this Bug: 793584 Change-Id: Ie1fe5b9fa24ae736dbd27fb14ef977442d233e89 Reviewed-on: https://chromium-review.googlesource.com/891647 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#533417} [modify] https://crrev.com/28ec2ab2f5f3cf467e8987fbc7d6f8e883ba4c3b/chrome/android/java/res/layout/tabular_context_menu_page.xml [modify] https://crrev.com/28ec2ab2f5f3cf467e8987fbc7d6f8e883ba4c3b/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/28ec2ab2f5f3cf467e8987fbc7d6f8e883ba4c3b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java [modify] https://crrev.com/28ec2ab2f5f3cf467e8987fbc7d6f8e883ba4c3b/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUiTest.java
,
Jan 31 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pnangunoori@chromium.org
, Dec 11 2017