New issue
Advanced search Search tips

Issue 793542 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Network Config (Settings UI): Certificates not configured

Project Member Reported by steve...@chromium.org, Dec 9 2017

Issue description

The new Settings base network config does not configure certificates correctly.



 
Status: Fixed (was: Started)
Fix:
https://chromium-review.googlesource.com/c/chromium/src/+/818083

Labels: Merge-Request-64
This change only affects the new Settings based Network Config UI, which is behind a flag (--network-settings-config) in M64, but requires extensive user testing so having it available in 64 would be very helpful.

Project Member

Comment 3 by sheriffbot@chromium.org, Dec 10 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-64 Merge-Merged merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebd872f24696b143303ab0b862aaa490290a0718

commit ebd872f24696b143303ab0b862aaa490290a0718
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Dec 11 19:41:31 2017

NetworkConfig: Include all properties in new configs

This also fixes:
* VPN ONC signature
* Selected certificate overwritten when other fields change
* Un-configurable VPN fields now correctly disabled

TBR=stevenjb@chromium.org

(cherry picked from commit ebba406b71bf8b8d53868df5f3435247c0c29fb9)

Bug:  380937 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7a3e4872859df707d072e00a6a0cdfad110a8c5c
Reviewed-on: https://chromium-review.googlesource.com/818083
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522960}
Reviewed-on: https://chromium-review.googlesource.com/820102
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#141}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/ebd872f24696b143303ab0b862aaa490290a0718/chromeos/network/onc/onc_signature.cc
[modify] https://crrev.com/ebd872f24696b143303ab0b862aaa490290a0718/chromeos/test/data/network/shill_l2tpipsec.json
[modify] https://crrev.com/ebd872f24696b143303ab0b862aaa490290a0718/chromeos/test/data/network/shill_output_l2tpipsec.json
[modify] https://crrev.com/ebd872f24696b143303ab0b862aaa490290a0718/chromeos/test/data/network/shill_wifi_eap_tls.json
[modify] https://crrev.com/ebd872f24696b143303ab0b862aaa490290a0718/chromeos/test/data/network/translation_of_shill_l2tpipsec.onc
[modify] https://crrev.com/ebd872f24696b143303ab0b862aaa490290a0718/chromeos/test/data/network/translation_of_shill_wifi_eap_tls.onc
[modify] https://crrev.com/ebd872f24696b143303ab0b862aaa490290a0718/chromeos/test/data/network/valid_l2tpipsec.onc
[modify] https://crrev.com/ebd872f24696b143303ab0b862aaa490290a0718/chromeos/test/data/network/wifi_eap_tls.onc
[modify] https://crrev.com/ebd872f24696b143303ab0b862aaa490290a0718/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/ebd872f24696b143303ab0b862aaa490290a0718/ui/webui/resources/cr_components/chromeos/network/network_config.js

Sign in to add a comment