New issue
Advanced search Search tips

Issue 793534 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

BottomSheetNavigateTest#testNavigate flakes

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 9 2017

Issue description

Comment 1 by ctzsm@chromium.org, Dec 9 2017

Cc: baxley@chromium.org mdjones@chromium.org
Flakiness dashboard doesn't look good either.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=chrome_public_test_apk&tests=BottomSheetNavigateTest#testNavigate

I am going to disable this test.

ccing test author and OWNERS

Comment 2 by ctzsm@chromium.org, Dec 9 2017

Labels: -Sheriff-Chromium
cl https://chromium-review.googlesource.com/c/chromium/src/+/818524 is in cq 
Status: Assigned (was: Available)
Thanks for catching, and sorry for the breakage!

I'll dig into it on Monday.

Comment 4 by ctzsm@chromium.org, Dec 9 2017

Cc: -baxley@chromium.org
Owner: baxley@chromium.org
Thanks!
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5305069c2cf4ceb51b5f6c6ed8b3bc9faf61a860

commit 5305069c2cf4ceb51b5f6c6ed8b3bc9faf61a860
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Sat Dec 09 02:24:55 2017

Disable BottomSheetNavigateTest#testNavigate

Disabling BottomSheetNavigateTest#testNavigate since it flakes on
different builders.

TBR=baxley@chromium.org, mdjones@chromium.org

Bug:  793534 
Change-Id: I925bd3df6d2bfe6a59a0763509a46a39cbe3551d
Reviewed-on: https://chromium-review.googlesource.com/818524
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522964}
[modify] https://crrev.com/5305069c2cf4ceb51b5f6c6ed8b3bc9faf61a860/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigateTest.java

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3336f9ada6652d68dc5c2eceb19d02a97f44db97

commit 3336f9ada6652d68dc5c2eceb19d02a97f44db97
Author: Mike Baxley <baxley@chromium.org>
Date: Mon Dec 18 21:53:01 2017

Make bottom sheet test wait for sheet to animate.

When hiding the sheet, the test was not waiting for scrolling to
complete. this worked on some devices, but failed on the bots.

Bug:  793534 
Change-Id: I1dfaf7525dc848bcaf481a29c5be4efe42f38ccc
Reviewed-on: https://chromium-review.googlesource.com/829922
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524815}
[modify] https://crrev.com/3336f9ada6652d68dc5c2eceb19d02a97f44db97/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigateTest.java

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/672902f8a08cdffbafecac2cd11c1c8dc71c5c34

commit 672902f8a08cdffbafecac2cd11c1c8dc71c5c34
Author: Mike Baxley <baxley@chromium.org>
Date: Mon Dec 18 23:49:52 2017

Revert "Make bottom sheet test wait for sheet to animate."

This reverts commit 3336f9ada6652d68dc5c2eceb19d02a97f44db97.

Reason for revert: Okay, I looked on the bot and it looks like the second run is failing. I'll revert this and see if I can find a device to repro on...

Original change's description:
> Make bottom sheet test wait for sheet to animate.
> 
> When hiding the sheet, the test was not waiting for scrolling to
> complete. this worked on some devices, but failed on the bots.
> 
> Bug:  793534 
> Change-Id: I1dfaf7525dc848bcaf481a29c5be4efe42f38ccc
> Reviewed-on: https://chromium-review.googlesource.com/829922
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Commit-Queue: Mike Baxley <baxley@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524815}

TBR=mdjones@chromium.org,baxley@chromium.org

Change-Id: I504a439faea3b3ef3f14d5dee236dfed9f591290
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  793534 
Reviewed-on: https://chromium-review.googlesource.com/833308
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524865}
[modify] https://crrev.com/672902f8a08cdffbafecac2cd11c1c8dc71c5c34/chrome/android/javatests/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigateTest.java

Comment 8 by baxley@chromium.org, Dec 18 2017

Okay, that attempt still appears to flake. The second run on KitKat phone rel failed:
https://luci-milo.appspot.com/buildbot/chromium.android/KitKat%20Phone%20Tester%20(rel)/1659

I  399.880s run_tests_on_device(06ae48fe003b6c18)    Error in testNavigate(org.chromium.chrome.browser.widget.bottomsheet.BottomSheetNavigateTest):
I  399.880s run_tests_on_device(06ae48fe003b6c18)    java.lang.AssertionError: Bottom sheet should be closed. expected:<0> but was:<3>

Comment 9 by baxley@chromium.org, Feb 13 2018

Owner: aluo@chromium.org
Assigning to aluo@, since I'm leaving. If you can't work on this, or this test doesn't make sense any more, then feel free to re-assign/close.

Here is the CL where I landed it:
https://chromium-review.googlesource.com/c/chromium/src/+/829922/2

In patch 2 - it *seemed* to work by polling.
I modified it when landing to call endAnimations, which worked locally but was flaky on some bots.

going forward, I'd investigate why endAnimations failed, and see if we need to use poling.

Comment 10 by aluo@chromium.org, Apr 18 2018

Status: WontFix (was: Assigned)
This test has been removed by https://chromium-review.googlesource.com/876529, closing issue.

Sign in to add a comment