FATAL typing into omnibox |
||||
Issue descriptionI was typing, backspacing, and typing more into the omnibox. This was my 3rd tab, I had just launched Chrome. Fewer than 6 characters in my omnibox at the time of the crash. [141603:141603:1208/171036.753019:FATAL:l10n_util.cc(733)] Check failed: std::string::npos == pos (18446744073709551615 vs. 0) Unexpectedly found a $2 placeholder in $2 $1 location from history #0 0x7f9c4f8fce1d base::debug::StackTrace::StackTrace() #1 0x7f9c4f8fb24c base::debug::StackTrace::StackTrace() #2 0x7f9c4f982fea logging::LogMessage::~LogMessage() #3 0x7f9c4f6b5cc5 l10n_util::GetStringFUTF16() #4 0x7f9c4f6b6039 l10n_util::GetStringFUTF16() #5 0x558cab357302 AutocompleteMatchType::ToAccessibilityLabel() #6 0x558cab98ccd3 OmniboxViewViews::OnTemporaryTextMaybeChanged() #7 0x558cab4a33b1 OmniboxEditModel::OnPopupDataChanged() #8 0x558cab4a6dde OmniboxPopupModel::SetSelectedLine() #9 0x558cab4a7089 OmniboxPopupModel::Move() #10 0x558cab4a24bd OmniboxEditModel::OnUpOrDownKeyPressed() #11 0x558cab990508 OmniboxViewViews::ExecuteTextEditCommand() #12 0x558cab9909c3 OmniboxViewViews::HandleKeyEvent() #13 0x7f9c426afedb views::Textfield::OnKeyPressed() #14 0x7f9c427056b1 views::View::OnKeyEvent() #15 0x7f9c453b5c23 ui::EventHandler::OnEvent() #16 0x7f9c453b4420 ui::EventDispatcher::DispatchEvent() #17 0x7f9c453b2bc2 ui::EventDispatcher::ProcessEvent() #18 0x7f9c453b264f ui::EventDispatcherDelegate::DispatchEventToTarget() #19 0x7f9c453b24ff ui::EventDispatcherDelegate::DispatchEvent() #20 0x7f9c453b7336 ui::EventProcessor::OnEventFromSource() #21 0x7f9c453b768c ui::EventProcessor::OnEventFromSource() #22 0x7f9c453b949f ui::EventSource::DeliverEventToSink() #23 0x7f9c453b8c91 ui::EventSource::SendEventToSink() #24 0x7f9c4272336b views::Widget::OnKeyEvent() #25 0x7f9c4275bcfe views::DesktopNativeWidgetAura::OnKeyEvent() #26 0x7f9c453b5c23 ui::EventHandler::OnEvent() #27 0x7f9c453b4420 ui::EventDispatcher::DispatchEvent() #28 0x7f9c453b2bc2 ui::EventDispatcher::ProcessEvent() #29 0x7f9c453b264f ui::EventDispatcherDelegate::DispatchEventToTarget() #30 0x7f9c453b24ff ui::EventDispatcherDelegate::DispatchEvent() #31 0x7f9c453b7336 ui::EventProcessor::OnEventFromSource() #32 0x7f9c453b768c ui::EventProcessor::OnEventFromSource() #33 0x7f9c44e729bf aura::WindowTreeHost::DispatchKeyEventPostIME() #34 0x7f9c4536f75b ui::InputMethodBase::DispatchKeyEventPostIME() #35 0x7f9c45369a14 ui::InputMethodAuraLinux::ProcessKeyEventDone() #36 0x7f9c45368b50 ui::InputMethodAuraLinux::DispatchKeyEvent() #37 0x7f9c44e60dba aura::WindowEventDispatcher::PreDispatchKeyEvent() #38 0x7f9c44e5ffb6 aura::WindowEventDispatcher::PreDispatchEvent() #39 0x7f9c453b24b0 ui::EventDispatcherDelegate::DispatchEvent() #40 0x7f9c453b7336 ui::EventProcessor::OnEventFromSource() #41 0x7f9c453b768c ui::EventProcessor::OnEventFromSource() #42 0x7f9c453b949f ui::EventSource::DeliverEventToSink() #43 0x7f9c453b8c91 ui::EventSource::SendEventToSink() #44 0x7f9c42788048 views::DesktopWindowTreeHostX11::DispatchKeyEvent() #45 0x7f9c427883fc views::DesktopWindowTreeHostX11::DispatchEvent() #46 0x7f9c4dfc2a14 ui::PlatformEventSource::DispatchEvent() #47 0x7f9c36161794 ui::X11EventSourceGlib::ProcessXEvent() #48 0x7f9c3614fcb8 ui::X11EventSource::ExtractCookieDataDispatchEvent() #49 0x7f9c3614fc20 ui::X11EventSource::DispatchXEvents() #50 0x7f9c36161b75 ui::(anonymous namespace)::XSourceDispatch() #51 0x7f9c37eb8ce5 g_main_context_dispatch #52 0x7f9c37eb9048 <unknown> #53 0x7f9c37eb90ec g_main_context_iteration #54 0x7f9c4f9ac1af base::MessagePumpGlib::Run() #55 0x7f9c4f9a7b5e base::MessageLoop::Run() #56 0x7f9c4fa54c5c base::RunLoop::Run() #57 0x558ca78c006d ChromeBrowserMainParts::MainMessageLoopRun() #58 0x7f9c49aeef76 content::BrowserMainLoop::RunMainMessageLoopParts() #59 0x7f9c49af783f content::BrowserMainRunnerImpl::Run() #60 0x7f9c49ae290b content::BrowserMain() #61 0x7f9c4b6e9c68 content::RunNamedProcessTypeMain()
,
Dec 9 2017
Looks like a bug with accessibility labels, probably IDS_ACC_AUTOCOMPLETE_HISTORY and its associated code from https://chromium-review.googlesource.com/c/chromium/src/+/728900 I think we're somehow making a call to that message translation string (which takes two parameters) using a call that only has one parameter. I believe this means the title (description) is blank, so we're trying to use the one-parameter call, but using a two-parameter message string. Updating priority because this will cause bad UI in the wild for users with accessibility turned on.
,
Dec 11 2017
That CL did add the involved code, but the second parameter was introduced by <https://chromium-review.googlesource.com/780239>, so I think this bug should go to aleventhal@.
,
Dec 11 2017
This might fix it: https://chromium-review.googlesource.com/c/chromium/src/+/817956 I'll figure it out either way.
,
Dec 11 2017
This should be already fixed by the merged-in changes from comment 4. It bases the number of params for the call on the message type rather than whether there is an empty description.
,
Dec 11 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by s...@chromium.org
, Dec 9 2017