browser_tests failing with DCHECK in autofill::ValidationRulesStorageFactory::~ValidationRulesStorageFactory |
||||||
Issue descriptionSeen here: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/62516 https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/62449 https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/62478 and more generally on multiple tryjobs here: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/?limit=200 Different shards of browser_tests are failing with this DCHECK: [6068:256:1208/150321.235:FATAL:observer_list.h(210)] Check failed: observers_.empty(). Backtrace: base::debug::StackTrace::StackTrace [0x02416FC0+32] base::debug::StackTrace::StackTrace [0x023D65AD+13] logging::LogMessage::~LogMessage [0x023833EE+78] base::ObserverList<views::WindowsSessionChangeObserver,1>::~ObserverList<views::WindowsSessionChangeObserver,1> [0x0425AAFF+91] JsonPrefStore::~JsonPrefStore [0x0351A3B1+225] JsonPrefStore::`scalar deleting destructor' [0x03519B3B+11] autofill::ValidationRulesStorageFactory::~ValidationRulesStorageFactory [0x04110332+38] base::LazyInstance<autofill::ValidationRulesStorageFactory,base::internal::DestructorAtExitLazyInstanceTraits<autofill::ValidationRulesStorageFactory> >::OnExit [0x05624FDE+14] base::internal::Invoker<base::internal::BindState<void (__cdecl*)(enum FlushMode),enum FlushMode>,void __cdecl(void)>::RunOnce [0x0522F23C+12] base::AtExitManager::ProcessCallbacksNow [0x023DE64B+299] base::AtExitManager::~AtExitManager [0x023DE413+115] std::unique_ptr<base::AtExitManager,std::default_delete<base::AtExitManager> >::~unique_ptr<base::AtExitManager,std::default_delete<base::AtExitManager> > [0x02362E1B+17] ChromeTestSuiteRunner::RunTestSuite [0x054FE8B4+84] content::LaunchTests [0x024ED982+389] LaunchChromeTests [0x054FEBC3+143] main [0x054FE821+109] __scrt_common_main_seh [0x06144C7A+248] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) BaseThreadInitThunk [0x7573336A+18] RtlInitializeExceptionChain [0x77919882+99] RtlInitializeExceptionChain [0x77919855+54] When this is hit, the entire shard fails. It doesn't report individual tests as failing. Diagnosing and fixing this is urgent. Marking P1.
,
Dec 9 2017
,
Dec 9 2017
Seeing many assertion failures in browser_tests in some tryjobs: AllTests/ChromeCleanerRebootFlowTest.OnRebootRequired_SettingsPageNotActive/0 StartupMetricsTest.ReportsValues OnSignInChangedEventTest.FireOnPrimaryAccountSignIn UserInitiatedRunsEnabled/ReporterRunnerTest.GeneralFailure/1_UserInitiatedWithLogsDisallowed_EmptySeed_Seed1 UserInitiatedRunsEnabled/ReporterRunnerTest.CleanupNeeded/1_UserInitiatedWithLogsAllowed_EmptySeed_EmptySeed SpellingMenuObserverTest.InitMenuWithCorrectWord SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/1 IdentityGetAccountsFunctionTest.PrimaryAccountHasNoRefreshToken See https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/62656 .
,
Dec 9 2017
https://chromium-review.googlesource.com/806715 seems the likeliest root cause of this bug. Reverting.
,
Dec 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3c8e19beafb7cae637ce0ac181699477cb8cdbc commit c3c8e19beafb7cae637ce0ac181699477cb8cdbc Author: Kenneth Russell <kbr@chromium.org> Date: Sat Dec 09 16:11:06 2017 Revert "[Autofill] Create AddressValidator in a background task." This reverts commit dedd6128557ac421342b4103c60f32240e58a191. Reason for revert: Likely cause of http://crbug.com/793520 . Original change's description: > [Autofill] Create AddressValidator in a background task. > > Will start a background task to create an AddressValidator in the > constructor. > > When the AddressValidator is loaded, it will load rules for any > pending normalization request. > > Bug: 789711 > Change-Id: I59542f6a1bbaba1a58805ab3d51fa7c7b1ceeff3 > Reviewed-on: https://chromium-review.googlesource.com/806715 > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Mathieu Perreault <mathp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522875} TBR=rogerm@chromium.org,fdoray@chromium.org,mathp@chromium.org NOTRY=true Change-Id: Ifec15561b6e7a5466dfccb47922e8173e3666552 No-Tree-Checks: true Bug: 789711 , 793520 Reviewed-on: https://chromium-review.googlesource.com/817766 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#522999} [modify] https://crrev.com/c3c8e19beafb7cae637ce0ac181699477cb8cdbc/components/autofill/core/browser/address_normalizer_impl.cc [modify] https://crrev.com/c3c8e19beafb7cae637ce0ac181699477cb8cdbc/components/autofill/core/browser/address_normalizer_impl.h [modify] https://crrev.com/c3c8e19beafb7cae637ce0ac181699477cb8cdbc/components/autofill/core/browser/address_normalizer_impl_unittest.cc [modify] https://crrev.com/c3c8e19beafb7cae637ce0ac181699477cb8cdbc/components/autofill/core/browser/field_filler_unittest.cc
,
Dec 11 2017
,
Dec 14 2017
Relanded with the fix here: https://chromium-review.googlesource.com/c/chromium/src/+/819594 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kbr@chromium.org
, Dec 9 2017