New issue
Advanced search Search tips

Issue 793490 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

[Autofill] Send first six digits of PAN in GetUploadDetails request (implementation bug)

Project Member Reported by jsaul@google.com, Dec 8 2017

Issue description

This bug is for tracking the implementation progress of sending the first six digits of credit card PAN in the GetUploadDetails call to Payments when determining whether to offer upload save.  By doing so, we can avoid offering to save in cases that are likely to fail.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c2a1482498ef9594bfcb8b4a307964d93b48a8a

commit 5c2a1482498ef9594bfcb8b4a307964d93b48a8a
Author: Jared Saul <jsaul@google.com>
Date: Sat Dec 09 00:24:31 2017

Send first six digits of PAN in GetUploadDetails request

Bug:  793490 
Change-Id: I109a09fbbab979afa769bfae161dd5f3d7809007
Reviewed-on: https://chromium-review.googlesource.com/816084
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522933}
[modify] https://crrev.com/5c2a1482498ef9594bfcb8b4a307964d93b48a8a/chrome/browser/about_flags.cc
[modify] https://crrev.com/5c2a1482498ef9594bfcb8b4a307964d93b48a8a/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/5c2a1482498ef9594bfcb8b4a307964d93b48a8a/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/5c2a1482498ef9594bfcb8b4a307964d93b48a8a/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/5c2a1482498ef9594bfcb8b4a307964d93b48a8a/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/5c2a1482498ef9594bfcb8b4a307964d93b48a8a/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/5c2a1482498ef9594bfcb8b4a307964d93b48a8a/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/5c2a1482498ef9594bfcb8b4a307964d93b48a8a/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/5c2a1482498ef9594bfcb8b4a307964d93b48a8a/components/autofill/core/browser/payments/payments_client.h
[modify] https://crrev.com/5c2a1482498ef9594bfcb8b4a307964d93b48a8a/components/autofill/core/browser/payments/payments_client_unittest.cc
[modify] https://crrev.com/5c2a1482498ef9594bfcb8b4a307964d93b48a8a/tools/metrics/histograms/enums.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db75f306dd6169bcc32227373ba8b4c14ee5b64e

commit db75f306dd6169bcc32227373ba8b4c14ee5b64e
Author: Jared Saul <jsaul@google.com>
Date: Thu Dec 14 23:54:01 2017

Update waterfall testing config for new Chrome Upstream launches

Make the following changes:

* Remove AutofillUpstreamShowGoogleLogo and AutofillUpstreamShowNewUi.  The code has been updated to make those default.
* Add Mac to AutofillUpstreamRequestCvcIfMissing in preparation of the M64 launch.
* Add config for AutofillUpstreamSendDetectedValues and AutofillUpstreamSendPanFirstSix, part of the Upstream Partial Data Project targeting M65.

Bug:  736944 ,  789645 ,  793490 
Change-Id: If6888d203dbceb3dcba8d38184244375c9cb110a
Reviewed-on: https://chromium-review.googlesource.com/827631
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#524234}
[modify] https://crrev.com/db75f306dd6169bcc32227373ba8b4c14ee5b64e/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80577497b14d353352df68cffe093ae5e1a138a7

commit 80577497b14d353352df68cffe093ae5e1a138a7
Author: Jared Saul <jsaul@google.com>
Date: Fri Jan 05 18:59:31 2018

Remove AutofillUpstreamSendPanFirstSix from waterfall testing config

Bug:  793490 
Change-Id: I1d4bc796dc3d30105f621adb01857d0c127c3873
Reviewed-on: https://chromium-review.googlesource.com/851252
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#527337}
[modify] https://crrev.com/80577497b14d353352df68cffe093ae5e1a138a7/testing/variations/fieldtrial_testing_config.json

Comment 4 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Started)

Comment 5 by se...@chromium.org, May 14 2018

Cc: se...@chromium.org
Status: Assigned (was: Untriaged)
Hey Jared, what's the status of this? :)

Comment 6 by ma...@chromium.org, May 16 2018

Should probably transform this into a cleanup bug if we are not launching

Comment 7 by jsaul@google.com, May 16 2018

Good question.  The Payments team still wants this as it will provide a much better Upstream experience, but I know there was some pushback.  Let me start a quick thread on this to see where we stand.  Definitely happy to clean it up if it looks like we won't be using it.
Status: WontFix (was: Assigned)
Abandoning project; cleanup bug is crbug.com/876893.

Sign in to add a comment