[CRD iOS] App keeps sending mousedown events during drag |
|||||
Issue descriptionWhat steps will reproduce the problem? (1) Connect to a Windows host (e.g. Windows 10 Home v1607) (2) Try to use the long-press gesture to draw a drag-select box What is the expected result? The drag-select box is drawn properly What happens instead? The starting point of the drag-select box is reset in every mouse movement. Looks like the problem is in this line of code: https://cs.chromium.org/chromium/src/remoting/client/gesture_interpreter.cc?sq=package:chromium&l=113 During drag mode we have the "left button pressed" information attached to each mouse movement event, and apparently Windows host interprets them as mousedown events and resets the drag starting point.
,
Dec 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2b5834286485964af1be2f95b9c3159a0fab34d commit a2b5834286485964af1be2f95b9c3159a0fab34d Author: Yuwei Huang <yuweih@chromium.org> Date: Sat Dec 09 00:41:21 2017 [CRD iOS] Remove mouse button state from mousemove event in drag gesture Previously we keep sending the "left button down" info with the mousemove event to the host during a drag gesture, which is interpreted as mousedown on Windows. This CL fixes this issue by removing the button state from the mouse event when it is a mousemove event in a drag gesture. Bug: 793481 Change-Id: Ifc2f9a4c0513df5f7f80223cae0c718b6f95ce1b Reviewed-on: https://chromium-review.googlesource.com/818326 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#522938} [modify] https://crrev.com/a2b5834286485964af1be2f95b9c3159a0fab34d/remoting/client/gesture_interpreter.cc
,
Dec 9 2017
This CL only affects Chrome Remote Desktop for iOS and will not affect Chrome.
,
Dec 10 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb96fb51cdcfcf7624e342c572a7909686eb0e59 commit cb96fb51cdcfcf7624e342c572a7909686eb0e59 Author: Yuwei Huang <yuweih@chromium.org> Date: Mon Dec 11 19:56:15 2017 [CRD iOS] Remove mouse button state from mousemove event in drag gesture Previously we keep sending the "left button down" info with the mousemove event to the host during a drag gesture, which is interpreted as mousedown on Windows. This CL fixes this issue by removing the button state from the mouse event when it is a mousemove event in a drag gesture. Bug: 793481 Change-Id: Ifc2f9a4c0513df5f7f80223cae0c718b6f95ce1b Reviewed-on: https://chromium-review.googlesource.com/818326 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522938}(cherry picked from commit a2b5834286485964af1be2f95b9c3159a0fab34d) Reviewed-on: https://chromium-review.googlesource.com/820510 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#143} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/cb96fb51cdcfcf7624e342c572a7909686eb0e59/remoting/client/gesture_interpreter.cc
,
Dec 12 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by yuweih@chromium.org
, Dec 8 2017