RunnerTest.Run failure in gin_unittests: Check failed: (isolate->snapshot_blob()) == nullptr. |
|||||||||||||||
Issue descriptionFailure seen here: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/62404 The CL being tried is unrelated. This test is failing all over this trybot: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/?limit=200 The only CLs that are making it through the CQ are those that retry without patch. [ RUN ] RunnerTest.Run # # Fatal error in ../../v8/src/api.cc, line 8662 # Check failed: (isolate->snapshot_blob()) == nullptr. # Backtrace: base::debug::StackTrace::StackTrace [0x009D68E0+32] base::debug::StackTrace::StackTrace [0x009F571D+13] gin::V8Platform::GetStackTracePrinter [0x009ADD0F+47] V8_Fatal [0x00AF034D+109] v8::IsolateNewImpl [0x001F3E57+679] v8::Isolate::New [0x001F3BA7+39] gin::IsolateHolder::IsolateHolder [0x009AD1F3+233] gin::IsolateHolder::IsolateHolder [0x009AD0EC+58] gin::IsolateHolder::IsolateHolder [0x009AD094+44] gin::RunnerTest_Run_Test::TestBody [0x001CC115+117] testing::Test::Run [0x0098F624+176] testing::TestInfo::Run [0x0098FB0F+201] testing::TestCase::Run [0x0098FE9D+235] testing::internal::UnitTestImpl::RunAllTests [0x00993A31+625] testing::UnitTest::Run [0x009936E9+151] base::TestSuite::Run [0x00997BE4+100] base::LaunchUnitTests [0x00999083+439] base::LaunchUnitTests [0x00998F5A+142] main [0x001CC42C+116] __scrt_common_main_seh [0x00B31C2A+248] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) BaseThreadInitThunk [0x74E0336A+18] RtlInitializeExceptionChain [0x770D9902+99] RtlInitializeExceptionChain [0x770D98D5+54] I'm guessing the bug is in the V8 runtime. Not sure when this started.
,
Dec 8 2017
,
Dec 8 2017
,
Dec 8 2017
The reason this wasn't caught on the waterfall is that the Release bots aren't running with dcheck_always_on=true. This is a major gap in behavior and I've filed Issue 793484 about resolving it.
,
Dec 8 2017
,
Dec 8 2017
,
Dec 8 2017
,
Dec 8 2017
jkummerow@ graciously offered to help do a git bisect of this on his local builds with dcheck_always_on=true because the sheriffs aren't responding. Thanks Jakob.
,
Dec 8 2017
I was wrong; it is happening on the Debug bots. Here's the first failing build on Linux: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/68813
,
Dec 8 2017
It's almost surely: Remove AMD-style module support from gin/. https://chromium-review.googlesource.com/812172
,
Dec 8 2017
Sounds likely. I am reverting that CL now.
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8f25f1e37e561d17222773d869ca460e00d8fe1 commit a8f25f1e37e561d17222773d869ca460e00d8fe1 Author: Yuzhu Shen <yzshen@chromium.org> Date: Fri Dec 08 23:37:45 2017 Revert "Remove AMD-style module support from gin/." This reverts commit c1ab49a9e23036de2f94da601782da9985a9a481. Reason for revert: Likely the cause of RunnerTest.Run failure in gin_unittests: Check failed: (isolate->snapshot_blob()) == nullptr. Original change's description: > Remove AMD-style module support from gin/. > > Bug: 718047 > Change-Id: If480fff65a2e5993ed5143eede8354f890de3a3b > Reviewed-on: https://chromium-review.googlesource.com/812172 > Commit-Queue: Yuzhu Shen <yzshen@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522850} TBR=yzshen@chromium.org,jochen@chromium.org Change-Id: I4a6efb21dd7972994a06ddab1316fa43e5d3e060 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 718047 , 793480 Reviewed-on: https://chromium-review.googlesource.com/817373 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#522921} [modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc [modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/BUILD.gn [modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/console.cc [modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/console.h [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/file_module_provider.cc [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/file_module_provider.h [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_registry.cc [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_registry.h [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_registry_observer.h [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_registry_unittest.cc [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_registry_unittests.js [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_runner_delegate.cc [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/module_runner_delegate.h [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/timer.cc [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/timer.h [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/modules/timer_unittest.cc [modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/runner.h [modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/shell/gin_main.cc [modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/shell/hello_world.js [modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/shell_runner.cc [modify] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/shell_runner.h [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/expect.js [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/file.cc [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/file.h [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/file_runner.cc [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/file_runner.h [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/file_unittests.js [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/gc.cc [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/gc.h [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/gtest.cc [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/gtest.h [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/gtest_unittests.js [add] https://crrev.com/a8f25f1e37e561d17222773d869ca460e00d8fe1/gin/test/run_js_tests.cc
,
Dec 8 2017
When that CL landed, it failed gin_unittests: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/605383 But retrying without patch failed too, so the failure was ignored and the CL landed. Possibly that means that the test was failing before; or maybe the with-patch run left state around that broke the without-patch run.
,
Dec 8 2017
Is this test not run in debug on the waterfalls, or is the failure not occurring in a full debug configuration?
,
Dec 8 2017
See #9. I was wrong; it is failing on the waterfalls on the Debug bots.
,
Dec 8 2017
#14: See #9. Debug bots on the waterfall are failing (they're just slow). For Release bots, there is the discrepancy between CQ (failing with dcheck_always_on) and waterfall (passing without dchecks). I'm repro'ing locally with full Debug.
,
Dec 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1fb0a45400650b7a691cedf2c17108ea33b9a04 commit e1fb0a45400650b7a691cedf2c17108ea33b9a04 Author: Yuzhu Shen <yzshen@chromium.org> Date: Sat Dec 09 00:39:12 2017 Disable a failing test temporarily during investigation. BUG= 793480 TBR=jochen@chromium.org Change-Id: I2300d376d3c6d0c04e82ec74b3103a12fed04ecf Reviewed-on: https://chromium-review.googlesource.com/817951 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#522936} [modify] https://crrev.com/e1fb0a45400650b7a691cedf2c17108ea33b9a04/gin/shell_runner_unittest.cc
,
Dec 9 2017
,
Dec 9 2017
,
Dec 9 2017
,
Dec 9 2017
,
Dec 9 2017
yzshen@ found the commit that caused the underlying problem about 24h ago. Linking to the related bugs.
,
Dec 9 2017
Yes, my CL can trigger the fail. Please revert it if the issue cannot be fixed easily. I'm ooo by this Tuesday.
,
Dec 11 2017
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9b25af57b4dcb66c2642dbe87e6eef54a6fc430 commit a9b25af57b4dcb66c2642dbe87e6eef54a6fc430 Author: Yuzhu Shen <yzshen@chromium.org> Date: Mon Dec 11 22:30:26 2017 Fix missing config for gin_unittests. Bug: 793480 Change-Id: I02c9ae70759be31af025e5787a5683cd76bffc57 Reviewed-on: https://chromium-review.googlesource.com/818452 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523235} [modify] https://crrev.com/a9b25af57b4dcb66c2642dbe87e6eef54a6fc430/gin/BUILD.gn [modify] https://crrev.com/a9b25af57b4dcb66c2642dbe87e6eef54a6fc430/gin/shell_runner_unittest.cc
,
Dec 12 2017
|
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by kbr@chromium.org
, Dec 8 2017