Add metrics for usage of --isolate-origins |
|||||||||
Issue descriptionThis is a tracking bug for adding metrics to measure how --isolate-origins (set via a command-line flag or enterprise policy) is used in practice. Things of interest might be the size of the origin list, what kind of sites people end up isolating, etc.
,
Dec 11 2017
Requesting merge - I think the simple metrics change in #1 would be nice to have in M64.
,
Dec 11 2017
Approving merge to M64 Chrome OS.
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43148cd37bf83f2887828c386aafb9b13575bb4f commit 43148cd37bf83f2887828c386aafb9b13575bb4f Author: Alex Moshchuk <alexmos@chromium.org> Date: Mon Dec 11 23:13:41 2017 Add histogram for measuring the number of isolated origins (Merge to M64) TBR=alexmos@chromium.org (cherry picked from commit afd4cb3829c770a89f7da2577d6f7cbe298c685d) Bug: 793471 Change-Id: Ie4ef677b056f0ccd3bb642e4b2320c79ce14ed5e Reviewed-on: https://chromium-review.googlesource.com/815293 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522948} Reviewed-on: https://chromium-review.googlesource.com/820621 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#157} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/43148cd37bf83f2887828c386aafb9b13575bb4f/content/common/site_isolation_policy.cc [modify] https://crrev.com/43148cd37bf83f2887828c386aafb9b13575bb4f/tools/metrics/histograms/histograms.xml
,
Dec 12 2017
Also requesting merge for M63 - after chatting with nasko@ and creis@, we thought it'd be essential to have this (and fix for issue 794336 , which is coming soon) in M63 for site isolation usage there.
,
Dec 12 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 12 2017
How is the change looking in canary? Will it be safe to merge to M63?
,
Dec 13 2017
#7: I've checked it in Mac canary 65.0.3292.0 by checking chrome://histograms after specifying --isolate-origins, and it's working as intended. Also checked that the metric is already showing some data from canary. Should be a safe merge, as it's not changing any behavior - just recording a new metric when --isolate-origins flag is used.
,
Dec 13 2017
Thank you alexmos@. Approving merge to M63 branch 3239 based on comment #8. Please merge ASAP. Thank you.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/207b7651d583795cb62f2bfe9ae6866632d75337 commit 207b7651d583795cb62f2bfe9ae6866632d75337 Author: Alex Moshchuk <alexmos@chromium.org> Date: Wed Dec 13 00:48:27 2017 Add metrics to count how often site isolation flags get turned on. Bug: 794336 , 793471 Change-Id: I035823fe6cf0f2f063e58707f3b8a4eba6748ee8 Reviewed-on: https://chromium-review.googlesource.com/823246 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523628} [modify] https://crrev.com/207b7651d583795cb62f2bfe9ae6866632d75337/content/browser/browser_main_loop.cc [modify] https://crrev.com/207b7651d583795cb62f2bfe9ae6866632d75337/content/common/site_isolation_policy.cc [modify] https://crrev.com/207b7651d583795cb62f2bfe9ae6866632d75337/content/common/site_isolation_policy.h [modify] https://crrev.com/207b7651d583795cb62f2bfe9ae6866632d75337/tools/metrics/histograms/histograms.xml
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1e277d50629411d22ce9266d138255740a30a4e commit e1e277d50629411d22ce9266d138255740a30a4e Author: Alex Moshchuk <alexmos@chromium.org> Date: Wed Dec 13 00:53:50 2017 Add histogram for measuring the number of isolated origins. Bug: 793471 Change-Id: Ie4ef677b056f0ccd3bb642e4b2320c79ce14ed5e Reviewed-on: https://chromium-review.googlesource.com/815293 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522948}(cherry picked from commit afd4cb3829c770a89f7da2577d6f7cbe298c685d) Reviewed-on: https://chromium-review.googlesource.com/822925 Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#671} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/e1e277d50629411d22ce9266d138255740a30a4e/content/common/site_isolation_policy.cc [modify] https://crrev.com/e1e277d50629411d22ce9266d138255740a30a4e/tools/metrics/histograms/histograms.xml
,
Dec 13 2017
Metrics added and merged to both M64 and M63.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6fbb056aee60f54c887662d45733d3a5e1d7841 commit c6fbb056aee60f54c887662d45733d3a5e1d7841 Author: Nasko Oskov <nasko@chromium.org> Date: Wed Dec 13 17:32:00 2017 Add metrics to count how often site isolation flags get turned on. (Merge in M63) Bug: 794336 , 793471 TBR=nasko@chormium.org Change-Id: I035823fe6cf0f2f063e58707f3b8a4eba6748ee8 Reviewed-on: https://chromium-review.googlesource.com/823246 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523628} Reviewed-on: https://chromium-review.googlesource.com/824905 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#675} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/c6fbb056aee60f54c887662d45733d3a5e1d7841/content/browser/browser_main_loop.cc [modify] https://crrev.com/c6fbb056aee60f54c887662d45733d3a5e1d7841/content/common/site_isolation_policy.cc [modify] https://crrev.com/c6fbb056aee60f54c887662d45733d3a5e1d7841/content/common/site_isolation_policy.h [modify] https://crrev.com/c6fbb056aee60f54c887662d45733d3a5e1d7841/tools/metrics/histograms/histograms.xml
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1130f3449d61fec70168d65b11c93762e6db427 commit e1130f3449d61fec70168d65b11c93762e6db427 Author: Nasko Oskov <nasko@chromium.org> Date: Wed Dec 13 17:35:43 2017 Add metrics to count how often site isolation flags get turned on. (Merge in M64) Bug: 794336 , 793471 Change-Id: I035823fe6cf0f2f063e58707f3b8a4eba6748ee8 Reviewed-on: https://chromium-review.googlesource.com/823246 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523628} Reviewed-on: https://chromium-review.googlesource.com/824906 Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#204} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/e1130f3449d61fec70168d65b11c93762e6db427/content/browser/browser_main_loop.cc [modify] https://crrev.com/e1130f3449d61fec70168d65b11c93762e6db427/content/common/site_isolation_policy.cc [modify] https://crrev.com/e1130f3449d61fec70168d65b11c93762e6db427/content/common/site_isolation_policy.h [modify] https://crrev.com/e1130f3449d61fec70168d65b11c93762e6db427/tools/metrics/histograms/histograms.xml |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 9 2017