New issue
Advanced search Search tips

Issue 793468 link

Starred by 1 user
Status: Fixed
Owner:
aleventhal@chromium.org
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Screen reader reports search autocompletion in omnibox has having an answer

Project Member Reported by aleventhal@chromium.org, Dec 8 2017 
Steps:
With screen reader on, focus omnibox
Type qqq
Down arrow then up arrow

What happens:
Screen reader reads "QQQ answer Google search"

Expected:
"QQQ search"
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69a11d9f02b4a040825fef0cc44ead230566789f

commit 69a11d9f02b4a040825fef0cc44ead230566789f
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Mon Dec 11 21:01:52 2017

Do not treat omnibox search as answer

When arrow to search with screen reader, do not say "answer" unless there
really is an answer (such as the current weather).

Bug:  793468 
Change-Id: Ic7de2826796f1f62b552940c3b8bfefd1f2878a4
Reviewed-on: https://chromium-review.googlesource.com/817956
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523205}
[modify] https://crrev.com/69a11d9f02b4a040825fef0cc44ead230566789f/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/69a11d9f02b4a040825fef0cc44ead230566789f/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/69a11d9f02b4a040825fef0cc44ead230566789f/components/omnibox/browser/autocomplete_match_type.cc
[modify] https://crrev.com/69a11d9f02b4a040825fef0cc44ead230566789f/components/omnibox/browser/autocomplete_match_type.h
[modify] https://crrev.com/69a11d9f02b4a040825fef0cc44ead230566789f/components/omnibox/browser/autocomplete_match_type_unittest.cc

Comment 2 by aleventhal@chromium.org, Dec 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment