New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

M63 builders failing with INVALID_BUILD_DEFINITION on stabilize branch

Project Member Reported by gkihumba@google.com, Dec 8 2017

Issue description

Cc: pho...@chromium.org
Cc: nxia@chromium.org
Status: Started (was: Assigned)
I'm presuming this is related to the roll out of nxia's buildbucket scheduling changes for the release waterfall.
Labels: Merge-Request-63
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3043e79ef8e089b7627b1baa1b7df678701f1ee4

commit 3043e79ef8e089b7627b1baa1b7df678701f1ee4
Author: Don Garrett <dgarrett@google.com>
Date: Fri Dec 08 23:22:14 2017

scheduler_stages: Fix release waterfall builder names.

If a release waterfall builder is run with a different branch (such as
a stabilize branch), the wrong builder name is generated for the slave
builders when scheduling them.

BUG= chromium:793447 
TEST=run_tests

Change-Id: If19f5f0db2b457ed92aca5aa97573e8789eae162
Reviewed-on: https://chromium-review.googlesource.com/818307
Tested-by: Don Garrett <dgarrett@chromium.org>
Trybot-Ready: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/3043e79ef8e089b7627b1baa1b7df678701f1ee4/cbuildbot/stages/scheduler_stages.py
[modify] https://crrev.com/3043e79ef8e089b7627b1baa1b7df678701f1ee4/cbuildbot/stages/scheduler_stages_unittest.py

Project Member

Comment 5 by sheriffbot@chromium.org, Dec 8 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-63 Merge-Approved-63
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 8 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0d130b4dcb6650cbd7083a1244b76517fe95d75b

commit 0d130b4dcb6650cbd7083a1244b76517fe95d75b
Author: Don Garrett <dgarrett@google.com>
Date: Fri Dec 08 23:36:02 2017

scheduler_stages: Fix release waterfall builder names.

If a release waterfall builder is run with a different branch (such as
a stabilize branch), the wrong builder name is generated for the slave
builders when scheduling them.

BUG= chromium:793447 
TEST=run_tests

Change-Id: If19f5f0db2b457ed92aca5aa97573e8789eae162
Reviewed-on: https://chromium-review.googlesource.com/818307
Tested-by: Don Garrett <dgarrett@chromium.org>
Trybot-Ready: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>
(cherry picked from commit b84639b3fdd948e6513f1af16c0d1022499c083e)
Reviewed-on: https://chromium-review.googlesource.com/817712
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/0d130b4dcb6650cbd7083a1244b76517fe95d75b/cbuildbot/stages/scheduler_stages.py
[modify] https://crrev.com/0d130b4dcb6650cbd7083a1244b76517fe95d75b/cbuildbot/stages/scheduler_stages_unittest.py

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 9 2017

Labels: merge-merged-stabilize-10032.68.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8d03155c6a3f3d17405c992ed3d78e8dc6511bac

commit 8d03155c6a3f3d17405c992ed3d78e8dc6511bac
Author: Don Garrett <dgarrett@google.com>
Date: Sat Dec 09 00:05:24 2017

scheduler_stages: Fix release waterfall builder names.

If a release waterfall builder is run with a different branch (such as
a stabilize branch), the wrong builder name is generated for the slave
builders when scheduling them.

BUG= chromium:793447 
TEST=run_tests

Change-Id: If19f5f0db2b457ed92aca5aa97573e8789eae162
Reviewed-on: https://chromium-review.googlesource.com/818307
Tested-by: Don Garrett <dgarrett@chromium.org>
Trybot-Ready: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>
(cherry picked from commit 3043e79ef8e089b7627b1baa1b7df678701f1ee4)
Reviewed-on: https://chromium-review.googlesource.com/818401
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/8d03155c6a3f3d17405c992ed3d78e8dc6511bac/cbuildbot/stages/scheduler_stages.py
[modify] https://crrev.com/8d03155c6a3f3d17405c992ed3d78e8dc6511bac/cbuildbot/stages/scheduler_stages_unittest.py

Labels: Merge-Request-64 Merge-Request-62
This fix has been confirmed on the stabilize branch.
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 10 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 11 2017

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1a4c026f049d2dae9f3c6ce89dfb071a9e7c8eec

commit 1a4c026f049d2dae9f3c6ce89dfb071a9e7c8eec
Author: Don Garrett <dgarrett@google.com>
Date: Mon Dec 11 20:58:00 2017

scheduler_stages: Fix release waterfall builder names.

If a release waterfall builder is run with a different branch (such as
a stabilize branch), the wrong builder name is generated for the slave
builders when scheduling them.

BUG= chromium:793447 
TEST=run_tests

Change-Id: If19f5f0db2b457ed92aca5aa97573e8789eae162
Reviewed-on: https://chromium-review.googlesource.com/818307
Tested-by: Don Garrett <dgarrett@chromium.org>
Trybot-Ready: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>
(cherry picked from commit 3043e79ef8e089b7627b1baa1b7df678701f1ee4)
Reviewed-on: https://chromium-review.googlesource.com/820650
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/1a4c026f049d2dae9f3c6ce89dfb071a9e7c8eec/cbuildbot/stages/scheduler_stages.py
[modify] https://crrev.com/1a4c026f049d2dae9f3c6ce89dfb071a9e7c8eec/cbuildbot/stages/scheduler_stages_unittest.py

Status: Fixed (was: Started)
No need to go to R62, unless we create / use any stabilize branches there. Declaring victorcy.
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 11 2017

Labels: merge-merged-stabilize-10032.71.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5b2e3ba36cb26ebb4bc84faa1179aa0457d6e305

commit 5b2e3ba36cb26ebb4bc84faa1179aa0457d6e305
Author: Don Garrett <dgarrett@google.com>
Date: Mon Dec 11 23:46:54 2017

scheduler_stages: Fix release waterfall builder names.

If a release waterfall builder is run with a different branch (such as
a stabilize branch), the wrong builder name is generated for the slave
builders when scheduling them.

BUG= chromium:793447 
TEST=run_tests

Change-Id: If19f5f0db2b457ed92aca5aa97573e8789eae162
Reviewed-on: https://chromium-review.googlesource.com/818307
Tested-by: Don Garrett <dgarrett@chromium.org>
Trybot-Ready: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>
(cherry picked from commit 3043e79ef8e089b7627b1baa1b7df678701f1ee4)
Reviewed-on: https://chromium-review.googlesource.com/818401
Reviewed-by: Don Garrett <dgarrett@chromium.org>
(cherry picked from commit 8d03155c6a3f3d17405c992ed3d78e8dc6511bac)
Reviewed-on: https://chromium-review.googlesource.com/820655
Commit-Queue: Grace Kihumba <gkihumba@chromium.org>
Tested-by: Grace Kihumba <gkihumba@chromium.org>
Reviewed-by: Grace Kihumba <gkihumba@chromium.org>

[modify] https://crrev.com/5b2e3ba36cb26ebb4bc84faa1179aa0457d6e305/cbuildbot/stages/scheduler_stages.py
[modify] https://crrev.com/5b2e3ba36cb26ebb4bc84faa1179aa0457d6e305/cbuildbot/stages/scheduler_stages_unittest.py

Project Member

Comment 15 by sheriffbot@chromium.org, Feb 12 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Feb 16 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment