Issue metadata
Sign in to add a comment
|
10.3%-42.7% regression in media.desktop at 522186:522373 |
||||||||||||||||||||||
Issue descriptionRef didn't change, so looks like a real regression.
,
Dec 8 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14d951ec040000
,
Dec 8 2017
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14d951ec040000 gpu: Don't clear anonymous IO surfaces. By sunnyps@chromium.org ยท Thu Dec 07 03:04:36 2017 chromium @ ea6e12b3635b8f77966cd4bacc02c31b914e95c4 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Dec 12 2017
This is a memory tracking bug not a real regression. Fix is in review: https://chromium-review.googlesource.com/c/chromium/src/+/820618
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ae7694152d95471e5bb42e04a9a45e2bcd7587d commit 3ae7694152d95471e5bb42e04a9a45e2bcd7587d Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Dec 12 22:43:01 2017 gpu: Assign unique ids to anonymous io surfaces. crrev.com/804597 accidentally set gmb id for anonymous surfaces to 0 to use it as a hint for whether to clear surfaces. This causes a memory regression similar to the one before unique ids were introduced. Instead, client_id, which is 0 for anonymous images and non-zero otherwise, can be used for the same purpose. R=ccameron BUG= 793445 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I76b2fa6cf498b0f2727bef7983ebc063cfb5e9d0 Reviewed-on: https://chromium-review.googlesource.com/820618 Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#523580} [modify] https://crrev.com/3ae7694152d95471e5bb42e04a9a45e2bcd7587d/gpu/ipc/service/gpu_memory_buffer_factory_io_surface.cc [modify] https://crrev.com/3ae7694152d95471e5bb42e04a9a45e2bcd7587d/gpu/ipc/service/gpu_memory_buffer_factory_io_surface.h
,
Dec 14 2017
Seems to have recovered. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 8 2017