New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793445 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.3%-42.7% regression in media.desktop at 522186:522373

Project Member Reported by crouleau@chromium.org, Dec 8 2017

Issue description

Ref didn't change, so looks like a real regression.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=793445

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=8db4aff0a87a5438748667e8f45a5680a243267a28b3ce5003a844261bc88b8f


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14d951ec040000
Cc: sunn...@chromium.org ccameron@chromium.org reve...@chromium.org piman@chromium.org
Owner: sunn...@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14d951ec040000

gpu: Don't clear anonymous IO surfaces.
By sunnyps@chromium.org ยท Thu Dec 07 03:04:36 2017
chromium @ ea6e12b3635b8f77966cd4bacc02c31b914e95c4

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
This is a memory tracking bug not a real regression. Fix is in review: https://chromium-review.googlesource.com/c/chromium/src/+/820618
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ae7694152d95471e5bb42e04a9a45e2bcd7587d

commit 3ae7694152d95471e5bb42e04a9a45e2bcd7587d
Author: Sunny Sachanandani <sunnyps@chromium.org>
Date: Tue Dec 12 22:43:01 2017

gpu: Assign unique ids to anonymous io surfaces.

crrev.com/804597 accidentally set gmb id for anonymous surfaces to 0 to
use it as a hint for whether to clear surfaces. This causes a memory
regression similar to the one before unique ids were introduced.

Instead, client_id, which is 0 for anonymous images and non-zero
otherwise, can be used for the same purpose.

R=ccameron
BUG= 793445 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I76b2fa6cf498b0f2727bef7983ebc063cfb5e9d0
Reviewed-on: https://chromium-review.googlesource.com/820618
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523580}
[modify] https://crrev.com/3ae7694152d95471e5bb42e04a9a45e2bcd7587d/gpu/ipc/service/gpu_memory_buffer_factory_io_surface.cc
[modify] https://crrev.com/3ae7694152d95471e5bb42e04a9a45e2bcd7587d/gpu/ipc/service/gpu_memory_buffer_factory_io_surface.h

Components: Internals>GPU>Internals
Status: Fixed (was: Assigned)
Seems to have recovered.

Sign in to add a comment