New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793431 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome://settings page gets closed when user selects to "Forget WiFi" network while having an active LTE connection

Project Member Reported by dsunk...@chromium.org, Dec 8 2017

Issue description

Chrome Version: 10176.8.0_link
OS: Chrome OS
DUT: Link (Any cellular supported chromebook will do)

What steps will reproduce the problem?
(1) Recover DUT with 10176.8.0 and Sign on. 
(2) Connect to Cellular Network.
(3) Connect to any available WiFi network. 
(4) Navigate to chrome://settings screen and select the connected wifi network and click on "Forget"
(5) Connection to WiFi network gets disconnected and settings page get closed.

What is the expected result?
User should stay on WiFi settings page as was in previous builds.

What happens instead?
Settings page gets closed.


 
debug-logs_20171208-120601.tgz
111 KB Download
Dec 8, 2017 12_03 PM.webm
1.1 MB View Download
That's very strange. It looks like a render process crash; the Settings tab didn't close (it can't actually do that), it just went away.

Can you see what happens if you repro this from Settings in a window (i.e. navigate to Settings from the system tray)?

I tried to repo this from settings in a window from system tray and it works fine. It does not behave the way it did on browser.
Hrm. Can it be reproduced regularly in the tab? If so, please file a feedback report and provide a link, or attach the chrome log, maybe there is an error message there. Also, please check whether being connected to Cellular makes any difference; it shouldn't.

Hi Steven,
Yes, this can be constantly reproduced in the tab. 
I have attached the logs (debug logs). please let me know if feedback link is still needed. 
Disconnecting LTE (Cellular)link, does not make the page go away. That is if you disconnect cellular and try to forget WiFi connection, it works fine. 

Its only in this case (With LTE connection ON), the page goes away.
Hmm. I can not reproduce this on coral.

Those logs do not include the chrome user logs, and do not include the device event logs, both of which would be included in a feedback report.

Also, could you try opening a javascript console (ctrl-shift-j) first and reproducing?

Thanks!

I tried again and found out that issue only happens on protected WiFi network (that network which is protected with password).

If I connect to Google-Guest or AP which has open access, the issue does not happen.

Please find the logs below: 

https://feedback.corp.google.com/product/208/neutron?lView=rd&lReport=84777337864

java script error@:
newtab:8 SW registered
chrome-search://thumb2/https://www.google.com/?fb=https://www.google.com/webpagethumbnail?c=63&d=https://www.google.com/&r=4&s=154:96&a=w7J6xrZdRQhLXTto9Sb5rHK1-b0:1 GET chrome-search://thumb2/https://www.google.com/?fb=https://www.google.com/webpagethumbnail?c=63&d=https://www.google.com/&r=4&s=154:96&a=w7J6xrZdRQhLXTto9Sb5rHK1-b0 net::ERR_FAILED
www.google.com-1513018716607.log
3.1 KB View Download
Owner: steve...@chromium.org
Status: Started (was: Untriaged)
Ah, thanks for the extra repro info, I can now reproduce this.

It looks like we are navigating back past the main Settings page, which we shouldn't be able to do

Cc: brajkumar@chromium.org ajha@chromium.org
 Issue 793776  has been merged into this issue.
Hmm, I can not seem to successfully protect against navigating too far back. The code theoretically already does so, but window.history.back() appears to behave asynchronously in a way that makes testing this.currentRoute.depth unreliable.

However InternetDetailPageElement.close_() should clear this.guid to prevent extraneous requests and navigation anway which will fix this issue and the symptom in  issue 793776 .

Labels: M-64
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dbcb93d966fa4c0f486cd41e3eee36ba5a63b0b

commit 2dbcb93d966fa4c0f486cd41e3eee36ba5a63b0b
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Dec 11 21:55:36 2017

Network detail page: clear guid on close

Bug:  793431 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I83a7333fba300174f17814daa4606bbc66f2a2ff
Reviewed-on: https://chromium-review.googlesource.com/820355
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523225}
[modify] https://crrev.com/2dbcb93d966fa4c0f486cd41e3eee36ba5a63b0b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

Labels: -Pri-2 Merge-Request-64 Pri-1
Status: Fixed (was: Started)
Labels: -Merge-Request-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 13 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a78db86f20c5c6a0e91165a51032130c685c8ff0

commit a78db86f20c5c6a0e91165a51032130c685c8ff0
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Dec 13 22:41:24 2017

Network detail page: clear guid on close

TBR=stevenjb@chromium.org

(cherry picked from commit 2dbcb93d966fa4c0f486cd41e3eee36ba5a63b0b)

Bug:  793431 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I83a7333fba300174f17814daa4606bbc66f2a2ff
Reviewed-on: https://chromium-review.googlesource.com/820355
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523225}
Reviewed-on: https://chromium-review.googlesource.com/823080
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#215}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/a78db86f20c5c6a0e91165a51032130c685c8ff0/chrome/browser/resources/settings/internet_page/internet_detail_page.js

Status: Verified (was: Fixed)
Tested on Astronaut with image: M-65 10281.0.0 / 65.0.3312.0. 

Sign in to add a comment