WebViewTests/WebViewTest.LoadWebviewInsideIframe/1 is flaky on MSAN |
||||
Issue descriptionSee these flakes on the Linux MSAN tester: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/6441 https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/6435
,
Dec 8 2017
I suspect this is a separate issue from crbug.com/788914 . Since in the test we have a DomAutomationController which would ensure we had a ScriptContext in the iframe. Also, looking at the flakiness dashboard, we only appear to be having trouble with MSan; the rest look fine. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WebViewTests%2FWebViewTest.LoadWebviewInsideIframe%2F1
,
Dec 18 2017
More failures: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/6636 https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/6664
,
Dec 19 2017
So I've only been able to reproduce this locally once. It looks like the |webview.contentWindow.postMessage| is not getting through to the guest. In the meantime, I can disable this test for MSAN.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8f2534d9ec04929a85cf6e73f786ed83a6ac37c commit f8f2534d9ec04929a85cf6e73f786ed83a6ac37c Author: Kevin McNee <mcnee@chromium.org> Date: Tue Dec 19 15:17:49 2017 Disable LoadWebviewInsideIframe under MSAN WebViewTests/WebViewTest.LoadWebviewInsideIframe/1 is flaky under MSAN. Bug: 793422 Change-Id: I867113fc436c1574e79e4dc6b55666c42904f86c Reviewed-on: https://chromium-review.googlesource.com/832678 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#525038} [modify] https://crrev.com/f8f2534d9ec04929a85cf6e73f786ed83a6ac37c/chrome/browser/apps/guest_view/web_view_browsertest.cc
,
Dec 19 2017
It's also worth noting that the old /0 version of the test (GuestViewCrossProcessFrames disabled) was not flaky on MSAN.
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a18303412701d46a3dd35776012b9d3578521e89 commit a18303412701d46a3dd35776012b9d3578521e89 Author: Kevin McNee <mcnee@chromium.org> Date: Wed Jan 17 19:13:00 2018 OOPIF guest view: Don't ACK AttachToEmbedderFrame before the attachment. In the OOPIF based guest version of |attachImpl$| we call |AttachIframeGuest| and provide a callback to be run after the attachment is done. However, the callback is run before the frame is actually swapped for a remote frame, as evidenced by the contentWindow still being local when the callback is run. The relative order of |AttachToOuterWebContentsFrame| and |GuestViewMsg_AttachToEmbedderFrame_ACK| appears to have been accidentally changed in https://codereview.chromium.org/2472253002 We now send the ACK after the call to |AttachToOuterWebContentsFrame| so that the callback is run after the attachment. Similarly, we were dispatching queued events in GuestViewBase::DidAttach before the attachment. We now dispatch after the attachment and ACK, so that the correct contentWindow is available in JS when handling the events. Bug: 793422 Change-Id: Ib83a985e24134dfcfd79cc474a6b30056ca66960 Reviewed-on: https://chromium-review.googlesource.com/868277 Reviewed-by: Lucas Gadani <lfg@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#529841} [modify] https://crrev.com/a18303412701d46a3dd35776012b9d3578521e89/components/guest_view/browser/guest_view_base.cc [modify] https://crrev.com/a18303412701d46a3dd35776012b9d3578521e89/components/guest_view/browser/guest_view_base.h [modify] https://crrev.com/a18303412701d46a3dd35776012b9d3578521e89/components/guest_view/browser/guest_view_message_filter.cc
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bf7fba85eb32436e2ec557a21f88e42fc3bfd86 commit 1bf7fba85eb32436e2ec557a21f88e42fc3bfd86 Author: Kevin McNee <mcnee@chromium.org> Date: Fri Jan 19 15:37:49 2018 Reenable WebViewTest.LoadWebviewInsideIframe under MSan. I believe that https://chromium-review.googlesource.com/c/chromium/src/+/868277 fixes the issue which was causing this test to flake. Bug: 793422 Change-Id: Ie74a8dc9e3b36f609210db89b453960e0d8b7286 Reviewed-on: https://chromium-review.googlesource.com/875111 Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#530514} [modify] https://crrev.com/1bf7fba85eb32436e2ec557a21f88e42fc3bfd86/chrome/browser/apps/guest_view/web_view_browsertest.cc
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by lfg@chromium.org
, Dec 8 2017Owner: mcnee@chromium.org