CSS Grid children emits `scroll` event when using `fr` units and updating other cell's HTML
Reported by
aarek...@gmail.com,
Dec 8 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36 Steps to reproduce the problem: 1. Open attached reduced test case 2. Scroll down green box 3. Stop scrolling 4. Watch scroll event being emitted with every update of upper box value What is the expected behavior? Scroll event is no longer emitted once you stop scrolling What went wrong? Scroll event is being emitted with every update of upper box value Did this work before? N/A Does this work in other browsers? Yes Chrome version: 63.0.3239.84 Channel: stable OS Version: 10.0 Flash Version: Requires CSS `grid-template` to use `fr` units on scrollable element. Scrollable element doesn't have to be direct children of grid cell.
,
Dec 12 2017
Able to reproduce the issue on Mac 10.12.6, Win-10 and Ubuntu 14.04 using chrome reported version #63.0.3239.84 but the same is not reproducible in the latest canary #65.0.3291.0. Reverse Bisect Information: ===================== Good build: 64.0.3250.0 Revision(511680) Bad Build : 64.0.3249.0 Revision(511318) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/78e8587301d2ac0a10184eb91d4caeae95a3c396..4d12111d13eab4eaf1ea56c594aa3223e9092b19 From the above change log suspecting below change Change-Id: Ibe4c927f5101b7ceced433084ea81aa2cafdc4a2 Reviewed-on: https://chromium-review.googlesource.com/702437 jfernandez@ - Could you please check and merge the fix to M-64 if it is a valid candidate. Note: Adding label RBS as it seems to be a recent regression. Please feel free to remove the same if not appropriate. Thanks...!!
,
Dec 12 2017
I'll take a look.
,
Dec 12 2017
The https://chromium-review.googlesource.com/702437 patch indeed fixes this bug, originally reported in M63. As far as I know, this patch landed already in M64 so I'm not sure what's the request here. Do you want to merge the fix in M63 ? This bus is not a regression, so I'm not sure it's a good idea. I may be misunderstanding the issue, though.
,
Dec 13 2017
r511451 landed before the M64 branch point. It is much too late to merge into M63 at this point.
,
Dec 14 2017
,
Dec 14 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 15 2017
Has this been well tested and verified in Canary? We are already in M64 Beta. Can you please justify why this is needed for M64?
,
Dec 15 2017
It's huge issue with scrolling, along with scroll event being emitted scroll glitches. Try scrolling example with mouse wheel to the bottom, then back to the top. Attaching a video of the issue on W10 63.0.3239.84. It works fine on 64.0.3282.24 (chrome dev), if that's going to be the next release, the fix is already there. JSFiddle for easier access: https://jsfiddle.net/tnynsgzp/1/
,
Dec 18 2017
Seems like this is already fixed in M64 per comment #5,9. Removing Merge-Request label.
,
Aug 2
I am still facing this issue in Version 67.0.3396.99 (Official Build) (64-bit) Windows 10
,
Aug 2
It's fixed on stable (68.0.3440.84 64-bit W10) I remember facing this issue just a few weeks ago, so possibly the fix have been pushed just recently. Thanks for finally investigating and fixing by the way, the problem was reguraly interrupting my work in past months :) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by gov...@chromium.org
, Dec 8 2017Labels: Needs-Triage-M63