New issue
Advanced search Search tips

Issue 793408 link

Starred by 0 users
Status: Fixed
Owner:
parastoog@chromium.org
Closed: Jan 2018
Cc:
se...@chromium.org
wuandy@chromium.org
rogerm@chromium.org
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fill CVC (for credit card) by Autofill.

Project Member Reported by parastoog@chromium.org, Dec 8 2017 
For some websites, the CVC doesn't get filled by autofill after prompting the user, because the forms sections are not accurate:

Example Sites:
homedepot.com (Desktop)
Freepeople.com (Desktop)

expedia.com (Android)
williamssonoma.com (Android)
potterybarn.com (Android)


Also, the dropdown values for dates don't get filled.
homedepot.com (Desktop)
Freepeople.com (Desktop)

Comment 1 by parastoog@chromium.org, Dec 8 2017

Description: Show this description

Comment 2 by parastoog@chromium.org, Jan 5 2018

Description: Show this description

Comment 3 by parastoog@chromium.org, Jan 8 2018

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b

commit 05fc942cc97bad9f1f3a01cb139be1243ef6cd8b
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Tue Jan 09 21:16:35 2018

[Autofill] Fix the credit card section problem

Problem:

In some forms, there are hidden fields, which are the recurrence
of others, like having more than one expiration month.
This causes some problems when we are identifying the sections of
the form, because our heuristics assume one of a kind for each
section (one exp month  for one section, the second for another one.)

Solution:

Change the heuristics so that we assume only one credit card section
for each form, this way, all credit card fields will be in a single
section.

Fixes: freepeople.com (Desktop), Home Depot (Desktop),
       ysl.com (Desktop), and etc.

Bug:  793408 
Change-Id: Ic2987a38efa2bd3db1c8ce7c768e86e76481212b
Reviewed-on: https://chromium-review.googlesource.com/854772
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528113}
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/000_i18n_de.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/001_i18n_de2.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/002_i18n_en.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/003_i18n_es.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/004_i18n_fr.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/005_i18n_it.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/006_i18n_ja.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/008_i18n_pt.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/009_i18n_ru.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/010_i18n_zh_cn.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/011_i18n_zh_tw.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/013_autocomplete_attribute_basic.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/018_checkout_ae.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/020_checkout_cafepress.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/025_checkout_hsn.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/034_checkout_overstock.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/040_checkout_urbanoutfitters.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/063_register_officedepot.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/078_crbug_40687.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/081_crbug_64569.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/083_crbug_87517.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/084_crbug_93595.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/085_crbug_98152.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/086_crbug_98269.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/087_crbug_98286.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/088_crbug_98338.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/092_checkout_alaskaair.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/101_checkout_m_bestbuy.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/102_checkout_m_macys.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/103_checkout_peapod.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/104_checkout_m_kohls.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/105_checkout_m_lowes.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/106_checkout_m_amazon.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/107_checkout_m_apple.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/109_checkout_m_nordstroms.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/110_checkout_harryanddavid.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/111_checkout_virgin_america.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/114_cc_checkout_wayfair.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/116_cc_checkout_walgreens.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/117_cc_checkout_macys.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/118_checkout_cvs.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/127_bug_463986.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/128_bug_464002.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/129_bug_465053.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/130_bug_465576.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/131_bug_465587.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/132_bug_469012.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/133_bug_469472.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/134_bug_471748.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/135_bug_471831.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/136_bug_497850.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/137_bug_555010.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/138_cc_checkout_united.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/141_checkout_cc_keurig.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/142_cc_checkout_netaporter.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/143_cc_checkout_efollet.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/144_cc_checkout_m_jcp.com.out
[modify] https://crrev.com/05fc942cc97bad9f1f3a01cb139be1243ef6cd8b/components/test/data/autofill/heuristics/output/148_payment_dickblick.com.out

Comment 5 by parastoog@chromium.org, Jan 9 2018

Status: Fixed (was: Started)
►

Sign in to add a comment