New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793405 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
Proj-XR
Proj-XR-VR

Blocked on:
issue 793977

Blocking:
issue 715118



Sign in to add a comment

Assets Component: Load environment asset file and make it available to the UI

Project Member Reported by tiborg@chromium.org, Dec 8 2017

Issue description

When entering VR Browsing Mode we have to load the environment file into memory so that it can be uploaded to a texture.
 

Comment 1 by tiborg@chromium.org, Dec 11 2017

Blockedon: 793977

Comment 2 by tiborg@chromium.org, Dec 13 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3387c940adba86adcdac0f4e4cc9870c2acf142

commit a3387c940adba86adcdac0f4e4cc9870c2acf142
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Dec 14 18:25:02 2017

[vr] Use asset component version 1.y

This change configures Chrome to
- Download asset component version 1.y,
- Load and decode background.png/.jpeg,
- Only register assets component on Chromes (not Chromiums).

Bug: 793977,  793405 , 793384
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I33de68ac0c3317360c0e26ae4274242e87092ff5
Reviewed-on: https://chromium-review.googlesource.com/822835
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524117}
[modify] https://crrev.com/a3387c940adba86adcdac0f4e4cc9870c2acf142/chrome/browser/BUILD.gn
[modify] https://crrev.com/a3387c940adba86adcdac0f4e4cc9870c2acf142/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/a3387c940adba86adcdac0f4e4cc9870c2acf142/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/a3387c940adba86adcdac0f4e4cc9870c2acf142/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/a3387c940adba86adcdac0f4e4cc9870c2acf142/chrome/browser/vr/assets.cc
[modify] https://crrev.com/a3387c940adba86adcdac0f4e4cc9870c2acf142/chrome/browser/vr/assets.h
[modify] https://crrev.com/a3387c940adba86adcdac0f4e4cc9870c2acf142/chrome/browser/vr/assets_load_status.h
[add] https://crrev.com/a3387c940adba86adcdac0f4e4cc9870c2acf142/chrome/browser/vr/features.gni
[modify] https://crrev.com/a3387c940adba86adcdac0f4e4cc9870c2acf142/tools/metrics/histograms/enums.xml

Comment 4 by tiborg@chromium.org, Dec 14 2017

Status: Fixed (was: Started)
Background image gets loaded and decoded now.
Labels: Test-Complete

Sign in to add a comment