New issue
Advanced search Search tips

Issue 793400 link

Starred by 1 user
Status: Fixed
Owner:
wuandy@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[autofill] Fill invalid phone numbers.

Project Member Reported by wuandy@chromium.org, Dec 8 2017 
At the moment autofill refuses to fill anything if the web site is asking
for a complete phone number but what user has saved is considered as 
invalid by libphonenumber. 

We should relex this restriction and fill the phone field with exactly what
the user has saved, as long as it's a field expecting complete number.

Also due to chrome's release cycle, some valid numbers might be considered invalid by libphonenumber because it does not have latest metadata.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b31c058c64fd8a7186b8103316abc120b385aec

commit 3b31c058c64fd8a7186b8103316abc120b385aec
Author: Hui(Andy) Wu <wuandy@chromium.org>
Date: Mon Dec 11 18:19:39 2017

[Autofill] Best effort filling for invalid phone numbers.

At the moment autofill refuses to fill anything if the web site is asking
for a complete phone number but what user has saved is considered as
invalid by libphonenumber.

We should relex this restriction and fill the phone field with exactly what
the user has saved, as long as it's a field expecting complete number.

Phone number components field will still be left empty.

Bug:  793400 
Change-Id: Ief7689185dfdf8c29526f620f80f95fed9a6d69c
Reviewed-on: https://chromium-review.googlesource.com/818015
Commit-Queue: Hui Wu <wuandy@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523140}
[modify] https://crrev.com/3b31c058c64fd8a7186b8103316abc120b385aec/components/autofill/core/browser/phone_number.cc
[modify] https://crrev.com/3b31c058c64fd8a7186b8103316abc120b385aec/components/autofill/core/browser/phone_number_unittest.cc

Comment 2 by wuandy@chromium.org, Dec 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment