New issue
Advanced search Search tips

Issue 793389 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
Proj-XR

Blocking:
issue 715118



Sign in to add a comment

Assets Component: Enable diff updates for incompatible components

Project Member Reported by tiborg@chromium.org, Dec 8 2017

Issue description

At the moment, if we encounter an incompatible component we will delete it and download a compatible one as a whole. Ensure that even when we encounter an incompatible we make use of diff update. This could be achieved by returning true from VrAssetsComponentInstallerTraits::VerifyInstallation (https://cs.chromium.org/chromium/src/chrome/browser/component_updater/vr_assets_component_installer.cc?rcl=16ba36d068f31cf13c7500516637327597667986&l=63) but don't forward assets in VrAssetsComponentInstallerTraits::ComponentReady (https://cs.chromium.org/chromium/src/chrome/browser/component_updater/vr_assets_component_installer.cc?rcl=16ba36d068f31cf13c7500516637327597667986&l=91).
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/571378abc48f1d85e5cfd0d339af015f2afd683e

commit 571378abc48f1d85e5cfd0d339af015f2afd683e
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Mon Dec 11 16:20:56 2017

[vr] Enable diff updates even if assets component is too old

Bug:  793389 
Change-Id: I82fe6000a5a16b5a44c9c383b041ab602fad2527
Reviewed-on: https://chromium-review.googlesource.com/817958
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523105}
[modify] https://crrev.com/571378abc48f1d85e5cfd0d339af015f2afd683e/chrome/browser/component_updater/vr_assets_component_installer.cc

Comment 3 by tiborg@chromium.org, Dec 11 2017

Status: Fixed (was: Started)
Labels: Test-Complete
Components: Internals>XR

Sign in to add a comment