New issue
Advanced search Search tips

Issue 793383 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Update Samba to 4.8.x

Project Member Reported by zentaro@chromium.org, Dec 8 2017

Issue description

Update Samba and it's dependencies.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/1a8b7c29446ebc4215e5e51cde6d4c0a1b8af407

commit 1a8b7c29446ebc4215e5e51cde6d4c0a1b8af407
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Mon Dec 11 20:47:46 2017

dev-util/cmocka: Add package at version 1.1.1

 - Changed EAPI from 6 to 5 (no v6 features were used)
 - Keywords to *
 - Removed unused patches from files/ (vs upstream gentoo)
 - New dependency when updating sys-libs/ldb (future CL)
 - Part of dependency chain updating net-fs/samba to 4.7.x

BUG= chromium:793383 
TEST=emerges

Change-Id: I79b1cc39fd4e9e29ffda1349bf44d6ee050da4b8
Reviewed-on: https://chromium-review.googlesource.com/817836
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/1a8b7c29446ebc4215e5e51cde6d4c0a1b8af407/dev-util/cmocka/cmocka-1.1.1.ebuild
[add] https://crrev.com/1a8b7c29446ebc4215e5e51cde6d4c0a1b8af407/dev-util/cmocka/Manifest
[add] https://crrev.com/1a8b7c29446ebc4215e5e51cde6d4c0a1b8af407/dev-util/cmocka/metadata.xml

Components: Enterprise
Summary: Update Samba to 4.8.x (was: Update Samba to 4.7.x)
Project Member

Comment 5 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/8f761df477e854f25aeaf424b9f0d45a901ebb95

commit 8f761df477e854f25aeaf424b9f0d45a901ebb95
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu May 10 22:08:51 2018

sys-lib/talloc Upgrade package to 2.1.11

- Keywords to *
- Part of dependency change to uprev net-fs/samba to 4.8.0

BUG= chromium:793383 
TEST=emerges

Change-Id: I46fb0588d0917fabd2985062c365ad52609fc88c
Reviewed-on: https://chromium-review.googlesource.com/984334
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/8f761df477e854f25aeaf424b9f0d45a901ebb95/sys-libs/talloc/talloc-2.1.11.ebuild
[modify] https://crrev.com/8f761df477e854f25aeaf424b9f0d45a901ebb95/sys-libs/talloc/Manifest

Project Member

Comment 6 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/f76b08bbc01df6850379318b22799ddd5e1eb3ba

commit f76b08bbc01df6850379318b22799ddd5e1eb3ba
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu May 10 22:08:52 2018

sys-lib/tevent Upgrade package to 0.9.36

- Keywords to *
- Part of dependency change to uprev net-fs/samba to 4.8.0

BUG= chromium:793383 
TEST=emerges

Change-Id: Id17f9e8a4ba22eb745a15d7dfd4e776bc7c72520
Reviewed-on: https://chromium-review.googlesource.com/984335
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/f76b08bbc01df6850379318b22799ddd5e1eb3ba/sys-libs/tevent/Manifest
[rename] https://crrev.com/f76b08bbc01df6850379318b22799ddd5e1eb3ba/sys-libs/tevent/tevent-0.9.36.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/ff1590ee66a4cbc27ecaecb34cc5bea2e20ccab6

commit ff1590ee66a4cbc27ecaecb34cc5bea2e20ccab6
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu May 10 22:08:52 2018

sys-libs/tdb: Upgrade package to 1.3.15

- Keywords to *
- Part of dependency chain updating net-fs/samba to 4.8.0
- [needed gentoo upstream] - Missing pkg_setup per [1]

[1] https://wiki.gentoo.org/wiki/Project:Python/waf-utils_integration

BUG= chromium:793383 
TEST=emerges

Change-Id: I2816d42dc1f84ca740e2eb1a6d2088752a13702f
Reviewed-on: https://chromium-review.googlesource.com/986492
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/ff1590ee66a4cbc27ecaecb34cc5bea2e20ccab6/sys-libs/tdb/Manifest
[rename] https://crrev.com/ff1590ee66a4cbc27ecaecb34cc5bea2e20ccab6/sys-libs/tdb/tdb-1.3.15.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/22c81e0f883604928c34c899bdb09cce6116ace8

commit 22c81e0f883604928c34c899bdb09cce6116ace8
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu May 10 22:08:50 2018

waf-utils.eclass: Update to the latest version of waf-utils.

- Needed to support EAPI 6.
- [push upstream] Add support for setting PKGCONFIG in configure.

BUG= chromium:793383 
TEST=emerges
CQ-DEPEND=CL:986493

Change-Id: I632f357dba45ef56b42ac085d951726e4fa5ab6e
Reviewed-on: https://chromium-review.googlesource.com/986638
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/22c81e0f883604928c34c899bdb09cce6116ace8/eclass/waf-utils.eclass

Project Member

Comment 10 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bcb51bbb41dd814f6967ec09806392627278cdf3

commit bcb51bbb41dd814f6967ec09806392627278cdf3
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu May 10 22:08:53 2018

sys-libs/ldb: This was moved to portage-stable during uprev.

- Part of uprev of net-fs/samba to 4.8.0

BUG= chromium:793383 
TEST=emerges
CQ-DEPEND=CL:989616
CQ-DEPEND=CL:986493

Change-Id: Ie0ad5491887fffce38eb309e824978a9e972ed3b
Reviewed-on: https://chromium-review.googlesource.com/986455
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/2d566fb2348db20aeabc9687c5c263acad74e3ad/sys-libs/ldb/files/ldb-1.1.29-allow_pkg_config_override.patch
[delete] https://crrev.com/2d566fb2348db20aeabc9687c5c263acad74e3ad/sys-libs/ldb/files/ldb-1.1.29-no_python_tdb.patch
[delete] https://crrev.com/2d566fb2348db20aeabc9687c5c263acad74e3ad/sys-libs/ldb/ldb-1.1.29-r2.ebuild
[delete] https://crrev.com/2d566fb2348db20aeabc9687c5c263acad74e3ad/sys-libs/ldb/Manifest
[delete] https://crrev.com/2d566fb2348db20aeabc9687c5c263acad74e3ad/sys-libs/ldb/files/ldb-1.1.27-optional_packages.patch
[delete] https://crrev.com/2d566fb2348db20aeabc9687c5c263acad74e3ad/sys-libs/ldb/files/ldb-1.1.29-no_python_tevent.patch
[delete] https://crrev.com/2d566fb2348db20aeabc9687c5c263acad74e3ad/sys-libs/ldb/ldb-1.1.29.ebuild
[delete] https://crrev.com/2d566fb2348db20aeabc9687c5c263acad74e3ad/sys-libs/ldb/metadata.xml

Project Member

Comment 11 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3a42cae343abf321e80d3d37131fd48e53af4a22

commit 3a42cae343abf321e80d3d37131fd48e53af4a22
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu May 10 22:08:54 2018

net-fs/samba: Upgrade package to 4.8.0

- Keywords to *
- Removed patches that are already landed in 4.8.0
- Rebased remaining patches so they apply on 4.8.0
- Add winbind package.use since it's now required by ads
- Disable following use flags that aren't needed
    -addc -addns -ceph -cluster -gpg -perl -test
- [needed upstream gentoo] - Missing perl use flag
- [needed upstream gentoo] - Missing python use flag
- [needed upstream gentoo] - Missing SYSROOT on tevent copy

BUG= chromium:793383 
TEST=emerges
CQ-DEPEND=CL:995437

Change-Id: I1d210c722713ce0afa8316ede2fef89b59bc9b17
Reviewed-on: https://chromium-review.googlesource.com/989615
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>

[add] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/files/samba-4.8.0-sec_init_uninit.patch
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-lib_server_role_missing_rpath.patch
[modify] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/files/4.4/samba4.initd-r1
[modify] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/Manifest
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-fix_cve_2017_7494.patch
[add] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/samba-4.8.0.ebuild
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-fix_block_inheritance.patch
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-skip_missing_ldap_attributes.patch
[rename] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/files/samba-4.8.0-reuse_existing_computer_account.patch
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-list_forced_gpos_last.patch
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-lib_interfaces_missing_rpath.patch
[modify] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/files/4.2/samba4.initd-r1
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-fix_cve_2017_9461.patch
[add] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/samba-4.8.0-r1.ebuild
[add] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/files/samba-4.5.1-compile_et_fix.patch
[modify] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/metadata.xml
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/samba-4.5.3-r15.ebuild
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-add_kerberos_enc_types.patch
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-fix-ftruncate-smb2.patch
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-reorder_ads_get_gpo_list.patch
[rename] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/files/samba-4.8.0-machinepass_expire.patch
[add] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/files/samba-4.8.0-improve_gss_init_sec_context_error_handing.patch
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/samba-4.5.3.ebuild
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-use_kerberos_enc_types.patch
[modify] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/profiles/targets/chromeos/package.use
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-improve_gss_init_sec_context_error_handing.patch
[rename] https://crrev.com/3a42cae343abf321e80d3d37131fd48e53af4a22/net-fs/samba/files/samba-4.8.0-machinepass_stdin.patch
[delete] https://crrev.com/bcb51bbb41dd814f6967ec09806392627278cdf3/net-fs/samba/files/samba-4.5.3-allow_pkg_config_override.patch

Project Member

Comment 12 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8abbdd35d99ab030c06108216bba5c9208f70333

commit 8abbdd35d99ab030c06108216bba5c9208f70333
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu May 10 22:08:55 2018

app-benchmark/glmark2: Support latest waf-utils eclass.

- latest waf-utils requires specific setup of python deps
- updated ebuild based on [1] (purely build-time)
- Add a prefixes to the paths in deprecated-auto-ptr.patch

[1] https://wiki.gentoo.org/wiki/Project:Python/waf-utils_integration

BUG= chromium:793383 
TEST=emerges

Change-Id: Id5afbd4a1af6134b5e5675b3ce92f7da9ac6d19b
Reviewed-on: https://chromium-review.googlesource.com/989616
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/8abbdd35d99ab030c06108216bba5c9208f70333/app-benchmarks/glmark2/glmark2-285-r15.ebuild
[modify] https://crrev.com/8abbdd35d99ab030c06108216bba5c9208f70333/app-benchmarks/glmark2/files/deprecated-auto-ptr.patch
[modify] https://crrev.com/8abbdd35d99ab030c06108216bba5c9208f70333/app-benchmarks/glmark2/glmark2-285.ebuild

Project Member

Comment 13 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/db3151c6e3933ea7cfd547e8ee05841549ef27cb

commit db3151c6e3933ea7cfd547e8ee05841549ef27cb
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu May 10 22:08:54 2018

authpolicy: Apply fixes for Samba 4.8.0

Applies a bunch of fixes so that authpolicy works with Samba 4.8.0.
- Whitelisted fallocate and kill in the net and smbclient seccomp
  policies.
- Added 'include system krb5 conf = false' to smb.conf. Without it,
  Samba tries to access /etc/krb5.conf, which we don't have.
- Removed 'client schannel = yes', it's deprecated and defaults to yes.
- Changed ownership of lock/cache/private/state folders to
  authpolicyd-exec. Samba verifies ownership now.
- Removed kKerberosParam from some commands where it wasn't necessary.
- Fixed up some error messages (found by the autotest!).

CQ-DEPEND=CL:989615

BUG= chromium:793383 
TEST=Performed domain join, user auth and policy fetch on a Chromad
     device.

Change-Id: If74e341a3f3c674b28185bb25840df936c3b7a23
Reviewed-on: https://chromium-review.googlesource.com/995437
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/db3151c6e3933ea7cfd547e8ee05841549ef27cb/authpolicy/seccomp_filters/net_ads-seccomp.policy
[modify] https://crrev.com/db3151c6e3933ea7cfd547e8ee05841549ef27cb/authpolicy/platform_helper.h
[modify] https://crrev.com/db3151c6e3933ea7cfd547e8ee05841549ef27cb/authpolicy/samba_interface.cc
[modify] https://crrev.com/db3151c6e3933ea7cfd547e8ee05841549ef27cb/authpolicy/seccomp_filters/smbclient-seccomp.policy

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified, Samba is updated to 4.8.0, performed domain join, user auth and policy fetch on a Chromad device, no issues.

localhost / # smbclient -V
Version 4.8.0
localhost / #

Chrome OS: 10760.0.0
Chrome: 69.0.3452.0
Device: Santa

Sign in to add a comment