New issue
Advanced search Search tips

Issue 793370 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue chromedriver:2282
issue chromedriver:2080



Sign in to add a comment

Add ChromeDriver python Desktop Tests to Commit Queue

Project Member Reported by crouleau@chromium.org, Dec 8 2017

Issue description

Blocking: chromedriver:2080
Cc: crouleau@chromium.org
Here's a prototype CL: https://chromium-review.googlesource.com/c/chromium/src/+/831052 The tests are failing in some cases though. See  issue 794017 .
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa7860c74a88b62a1cc2e0505777d4caf6a84dcb

commit aa7860c74a88b62a1cc2e0505777d4caf6a84dcb
Author: John Chen <johnchen@chromium.org>
Date: Tue Jan 23 14:56:54 2018

[ChromeDriver] Add ChromeDriver tests to Commit Queue

This is the initial check-in of the feature to add ChromeDriver tests
to commit queue. It includes the following:

* A new test target chromedriver_py_tests, to encapsulate dependencies
  needed to run the Python-based ChromeDriver tests. This target is
  currently enabled on Linux only. Other platforms will be added later.

* Only a single test case is enabled. Enabling additional test cases
  will be done later.

Bug:  793370 
Change-Id: I5a6f0568d2e78724a4fe53e84c3a480d770c3e47
Reviewed-on: https://chromium-review.googlesource.com/874816
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531234}
[modify] https://crrev.com/aa7860c74a88b62a1cc2e0505777d4caf6a84dcb/PRESUBMIT.py
[modify] https://crrev.com/aa7860c74a88b62a1cc2e0505777d4caf6a84dcb/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/aa7860c74a88b62a1cc2e0505777d4caf6a84dcb/chrome/test/chromedriver/test/run_py_tests.py
[add] https://crrev.com/aa7860c74a88b62a1cc2e0505777d4caf6a84dcb/chrome/test/chromedriver/test/run_py_tests.pydeps
[modify] https://crrev.com/aa7860c74a88b62a1cc2e0505777d4caf6a84dcb/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/aa7860c74a88b62a1cc2e0505777d4caf6a84dcb/testing/buildbot/chromium.sandbox.json
[modify] https://crrev.com/aa7860c74a88b62a1cc2e0505777d4caf6a84dcb/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/aa7860c74a88b62a1cc2e0505777d4caf6a84dcb/testing/buildbot/test_suites.pyl

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9de3051e3af2dec23fb303bd2784c8665a147f38

commit 9de3051e3af2dec23fb303bd2784c8665a147f38
Author: John Chen <johnchen@chromium.org>
Date: Wed Jan 24 01:39:21 2018

[ChromeDriver] Enable CQ tests on Mac/Windows

Previously, the commit queue only runs ChromeDriver tests on Linux.
This CL expands the test to other desktop platforms, including Mac
and Windows.

Bug:  793370 
Change-Id: I2a28d3a5c8371edc28566010739681acfac41c21
Reviewed-on: https://chromium-review.googlesource.com/881641
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531399}
[modify] https://crrev.com/9de3051e3af2dec23fb303bd2784c8665a147f38/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/9de3051e3af2dec23fb303bd2784c8665a147f38/chrome/test/chromedriver/test/run_py_tests.py
[modify] https://crrev.com/9de3051e3af2dec23fb303bd2784c8665a147f38/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/9de3051e3af2dec23fb303bd2784c8665a147f38/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9de3051e3af2dec23fb303bd2784c8665a147f38/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/9de3051e3af2dec23fb303bd2784c8665a147f38/testing/buildbot/chromium.win.json
[modify] https://crrev.com/9de3051e3af2dec23fb303bd2784c8665a147f38/testing/buildbot/test_suites.pyl

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd16c9a5dda0aedbd73dd8459bffe432d11e9941

commit bd16c9a5dda0aedbd73dd8459bffe432d11e9941
Author: Takashi Sakamoto <tasak@google.com>
Date: Wed Jan 24 03:49:19 2018

Revert "[ChromeDriver] Enable CQ tests on Mac/Windows"

This reverts commit 9de3051e3af2dec23fb303bd2784c8665a147f38.

Reason for revert: 
This causes Mac10.9 build bot failure. i.e.

chromedriver_py_tests chromedriver_py_tests
Run on OS: 'Mac-10.9'

Starting ChromeDriver 2.35.531399 (9de3051e3af2dec23fb303bd2784c8665a147f38) on port 9500
Only local connections are allowed.
testLoadUrl (__main__.ChromeDriverTest) ... ERROR

======================================================================
ERROR: testLoadUrl (__main__.ChromeDriverTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "../../chrome/test/chromedriver/test/run_py_tests.py", line 394, in setUp
    self._driver = self.CreateDriver()
  File "../../chrome/test/chromedriver/test/run_py_tests.py", line 316, in CreateDriver
    **kwargs)
  File "/b/swarm_slave/w/ir/chrome/test/chromedriver/test/../client/chromedriver.py", line 233, in __init__
    response = self._ExecuteCommand(Command.NEW_SESSION, params)
  File "/b/swarm_slave/w/ir/chrome/test/chromedriver/test/../client/chromedriver.py", line 284, in _ExecuteCommand
    response = self._executor.Execute(command, params)
  File "/b/swarm_slave/w/ir/chrome/test/chromedriver/test/../client/command_executor.py", line 193, in Execute
    response = self._http_client.getresponse()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1045, in getresponse
    response.begin()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 409, in begin
    version, status, reason = self._read_status()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 365, in _read_status
    line = self.fp.readline(_MAXLINE + 1)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 476, in readline
    data = self._sock.recv(self._rbufsize)
timeout: timed out

Original change's description:
> [ChromeDriver] Enable CQ tests on Mac/Windows
> 
> Previously, the commit queue only runs ChromeDriver tests on Linux.
> This CL expands the test to other desktop platforms, including Mac
> and Windows.
> 
> Bug:  793370 
> Change-Id: I2a28d3a5c8371edc28566010739681acfac41c21
> Reviewed-on: https://chromium-review.googlesource.com/881641
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531399}

TBR=crouleau@chromium.org,johnchen@chromium.org,jbudorick@chromium.org

Change-Id: Ic872389bc30057948d59443ba1481b7344cfbab6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  793370 
Reviewed-on: https://chromium-review.googlesource.com/882702
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#531421}
[modify] https://crrev.com/bd16c9a5dda0aedbd73dd8459bffe432d11e9941/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/bd16c9a5dda0aedbd73dd8459bffe432d11e9941/chrome/test/chromedriver/test/run_py_tests.py
[modify] https://crrev.com/bd16c9a5dda0aedbd73dd8459bffe432d11e9941/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/bd16c9a5dda0aedbd73dd8459bffe432d11e9941/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/bd16c9a5dda0aedbd73dd8459bffe432d11e9941/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/bd16c9a5dda0aedbd73dd8459bffe432d11e9941/testing/buildbot/chromium.win.json
[modify] https://crrev.com/bd16c9a5dda0aedbd73dd8459bffe432d11e9941/testing/buildbot/test_suites.pyl

This test is flaky on Linux also:

ERROR: testLoadUrl (__main__.ChromeDriverTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "../../chrome/test/chromedriver/test/run_py_tests.py", line 394, in setUp
    self._driver = self.CreateDriver()
  File "../../chrome/test/chromedriver/test/run_py_tests.py", line 316, in CreateDriver
    **kwargs)
  File "/b/s/w/ir/chrome/test/chromedriver/test/../client/chromedriver.py", line 233, in __init__
    response = self._ExecuteCommand(Command.NEW_SESSION, params)
  File "/b/s/w/ir/chrome/test/chromedriver/test/../client/chromedriver.py", line 284, in _ExecuteCommand
    response = self._executor.Execute(command, params)
  File "/b/s/w/ir/chrome/test/chromedriver/test/../client/command_executor.py", line 193, in Execute
    response = self._http_client.getresponse()
  File "/usr/lib/python2.7/httplib.py", line 1089, in getresponse
    response.begin()
  File "/usr/lib/python2.7/httplib.py", line 444, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python2.7/httplib.py", line 400, in _read_status
    line = self.fp.readline(_MAXLINE + 1)
  File "/usr/lib/python2.7/socket.py", line 476, in readline
    data = self._sock.recv(self._rbufsize)
timeout: timed out

----------------------------------------------------------------------
Ran 1 test in 30.012s

FAILED (errors=1)

For example:

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/69833
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/102db4c6874ee95104b7a0cb77a682a4a8862ca7

commit 102db4c6874ee95104b7a0cb77a682a4a8862ca7
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed Jan 24 13:11:21 2018

Revert "[ChromeDriver] Add ChromeDriver tests to Commit Queue"

This reverts commit aa7860c74a88b62a1cc2e0505777d4caf6a84dcb.

Reason for revert: this test is flaky on Linux: https://bugs.chromium.org/p/chromium/issues/detail?id=793370

Original change's description:
> [ChromeDriver] Add ChromeDriver tests to Commit Queue
> 
> This is the initial check-in of the feature to add ChromeDriver tests
> to commit queue. It includes the following:
> 
> * A new test target chromedriver_py_tests, to encapsulate dependencies
>   needed to run the Python-based ChromeDriver tests. This target is
>   currently enabled on Linux only. Other platforms will be added later.
> 
> * Only a single test case is enabled. Enabling additional test cases
>   will be done later.
> 
> Bug:  793370 
> Change-Id: I5a6f0568d2e78724a4fe53e84c3a480d770c3e47
> Reviewed-on: https://chromium-review.googlesource.com/874816
> Commit-Queue: John Chen <johnchen@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531234}

TBR=dcheng@chromium.org,crouleau@chromium.org,johnchen@chromium.org,jbudorick@chromium.org

Change-Id: I14b582a49b823adc5531fcb4070e8bec4f8d4b83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  793370 
Reviewed-on: https://chromium-review.googlesource.com/883641
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531514}
[modify] https://crrev.com/102db4c6874ee95104b7a0cb77a682a4a8862ca7/PRESUBMIT.py
[modify] https://crrev.com/102db4c6874ee95104b7a0cb77a682a4a8862ca7/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/102db4c6874ee95104b7a0cb77a682a4a8862ca7/chrome/test/chromedriver/test/run_py_tests.py
[delete] https://crrev.com/d6e0e7e4ca44b012889496041a4325b356dccba3/chrome/test/chromedriver/test/run_py_tests.pydeps
[modify] https://crrev.com/102db4c6874ee95104b7a0cb77a682a4a8862ca7/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/102db4c6874ee95104b7a0cb77a682a4a8862ca7/testing/buildbot/chromium.sandbox.json
[modify] https://crrev.com/102db4c6874ee95104b7a0cb77a682a4a8862ca7/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/102db4c6874ee95104b7a0cb77a682a4a8862ca7/testing/buildbot/test_suites.pyl

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cde8919d65a27735e2ecb47ade93fb4c3bdf17a6

commit cde8919d65a27735e2ecb47ade93fb4c3bdf17a6
Author: John Chen <johnchen@chromium.org>
Date: Sat Jan 27 21:18:40 2018

Reland "[ChromeDriver] Add ChromeDriver tests to Commit Queue"

This is a reland of aa7860c74a88b62a1cc2e0505777d4caf6a84dcb,
with the change to enable the ChromeDriver tests on release bot only.
The original commit was reverted due to flakiness of the tests on debug
build. The reason for the flakiness is debug build of Chrome takes a
long time to start, usually between 20 to 40 seconds. The timeout for
the test is 30 seconds, thus it can either succeed or fail depending
on whether Chrome started quick enough or not.

While it is possible to increase the timeout, spending over 30 seconds
per test appears to be too much overhead in the long run. Also, the
purpose of running these tests is to catch incompatibilities that can
develop between Chrome and ChromeDriver, and running these tests on
release builds should suffice for that purpose.

Original change's description:
> [ChromeDriver] Add ChromeDriver tests to Commit Queue
>
> This is the initial check-in of the feature to add ChromeDriver tests
> to commit queue. It includes the following:
>
> * A new test target chromedriver_py_tests, to encapsulate dependencies
>   needed to run the Python-based ChromeDriver tests. This target is
>   currently enabled on Linux only. Other platforms will be added later.
>
> * Only a single test case is enabled. Enabling additional test cases
>   will be done later.
>
> Bug:  793370 
> Change-Id: I5a6f0568d2e78724a4fe53e84c3a480d770c3e47
> Reviewed-on: https://chromium-review.googlesource.com/874816
> Commit-Queue: John Chen <johnchen@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531234}

Bug:  793370 
Change-Id: Ic8873c326dfcd676552083d6f90aba29cc046e67
Reviewed-on: https://chromium-review.googlesource.com/885082
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532252}
[modify] https://crrev.com/cde8919d65a27735e2ecb47ade93fb4c3bdf17a6/PRESUBMIT.py
[modify] https://crrev.com/cde8919d65a27735e2ecb47ade93fb4c3bdf17a6/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/cde8919d65a27735e2ecb47ade93fb4c3bdf17a6/chrome/test/chromedriver/test/run_py_tests.py
[add] https://crrev.com/cde8919d65a27735e2ecb47ade93fb4c3bdf17a6/chrome/test/chromedriver/test/run_py_tests.pydeps
[modify] https://crrev.com/cde8919d65a27735e2ecb47ade93fb4c3bdf17a6/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/cde8919d65a27735e2ecb47ade93fb4c3bdf17a6/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/cde8919d65a27735e2ecb47ade93fb4c3bdf17a6/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/cde8919d65a27735e2ecb47ade93fb4c3bdf17a6/testing/buildbot/waterfalls.pyl

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22b2e391ee394ab52f981c7bd04c84d0bbe8e94c

commit 22b2e391ee394ab52f981c7bd04c84d0bbe8e94c
Author: John Chen <johnchen@chromium.org>
Date: Tue Jan 30 17:02:30 2018

Reland "[ChromeDriver] Enable CQ tests on Mac/Windows"

This is a reland of 9de3051e3af2dec23fb303bd2784c8665a147f38,
with the change to enable the ChromeDriver tests on release bot only.
The original commit was reverted due to flakiness of the tests on debug
build. The reason for the flakiness is debug build of Chrome takes a
long time to start, usually between 20 to 40 seconds. The timeout for
the test is 30 seconds, thus it can either succeed or fail depending
on whether Chrome started quick enough or not.

While it is possible to increase the timeout, spending over 30 seconds
per test appears to be too much overhead in the long run. Also, the
purpose of running these tests is to catch incompatibilities that can
develop between Chrome and ChromeDriver, and running these tests on
release builds should suffice for that purpose.

Original change's description:
> [ChromeDriver] Enable CQ tests on Mac/Windows
>
> Previously, the commit queue only runs ChromeDriver tests on Linux.
> This CL expands the test to other desktop platforms, including Mac
> and Windows.
>
> Bug:  793370 
> Change-Id: I2a28d3a5c8371edc28566010739681acfac41c21
> Reviewed-on: https://chromium-review.googlesource.com/881641
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531399}

Bug:  793370 
Change-Id: I87df556896593ab9497435611a7d78122adbddd8
Reviewed-on: https://chromium-review.googlesource.com/890391
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532924}
[modify] https://crrev.com/22b2e391ee394ab52f981c7bd04c84d0bbe8e94c/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/22b2e391ee394ab52f981c7bd04c84d0bbe8e94c/chrome/test/chromedriver/test/run_py_tests.py
[modify] https://crrev.com/22b2e391ee394ab52f981c7bd04c84d0bbe8e94c/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/22b2e391ee394ab52f981c7bd04c84d0bbe8e94c/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/22b2e391ee394ab52f981c7bd04c84d0bbe8e94c/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/22b2e391ee394ab52f981c7bd04c84d0bbe8e94c/testing/buildbot/chromium.sandbox.json
[modify] https://crrev.com/22b2e391ee394ab52f981c7bd04c84d0bbe8e94c/testing/buildbot/chromium.win.json
[modify] https://crrev.com/22b2e391ee394ab52f981c7bd04c84d0bbe8e94c/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/22b2e391ee394ab52f981c7bd04c84d0bbe8e94c/testing/buildbot/waterfalls.pyl

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c9ce21ce16470c643d56f2371020423c1bc4cc8

commit 9c9ce21ce16470c643d56f2371020423c1bc4cc8
Author: John Chen <johnchen@chromium.org>
Date: Sun Feb 18 08:30:48 2018

[ChromeDriver] Additional ChromeDriver tests in CQ

Add most of the ChromeDriver tests into the chromedriver_py_tests target
that is run in the commit queue. Some tests are skipped for various
reasons: not reliable enough, not adding enough value for commit queue,
or requiring additional setup not yet available.

Bug:  793370 
Change-Id: Iec581b24e155b2dfb926cdba4899f26c173d2023
Reviewed-on: https://chromium-review.googlesource.com/919488
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537558}
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/chrome/test/chromedriver/test/run_py_tests.py
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/chromium.win.json
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/test_suites.pyl

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c9ce21ce16470c643d56f2371020423c1bc4cc8

commit 9c9ce21ce16470c643d56f2371020423c1bc4cc8
Author: John Chen <johnchen@chromium.org>
Date: Sun Feb 18 08:30:48 2018

[ChromeDriver] Additional ChromeDriver tests in CQ

Add most of the ChromeDriver tests into the chromedriver_py_tests target
that is run in the commit queue. Some tests are skipped for various
reasons: not reliable enough, not adding enough value for commit queue,
or requiring additional setup not yet available.

Bug:  793370 
Change-Id: Iec581b24e155b2dfb926cdba4899f26c173d2023
Reviewed-on: https://chromium-review.googlesource.com/919488
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537558}
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/chrome/test/chromedriver/test/run_py_tests.py
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/chromium.win.json
[modify] https://crrev.com/9c9ce21ce16470c643d56f2371020423c1bc4cc8/testing/buildbot/test_suites.pyl

Labels: -Type-Bug Type-Task
Status: Verified (was: Assigned)
The Python-based ChromeDriver tests are now running on the desktop builds in commit queue. I'm closing this bug, and opening two new bugs to track additional work in this area:

* Issue 813466 - Add ChromeDriver Tests on Android Builds in Commit Queue
* Issue 813467 - Add Java-Based Tests to Commit Queue

In addition, there are a few minor fix-ups for the Python-bases tests on desktop:

* Issue chromedriver:2277 - Enable RemoteBrowserTest on commit queue
* Issue chromedriver:2278 - Remove Use of LaunchApp from Extension Background Page Test
* Issue chromedriver:2279 - Reduce Number of Web Servers used in ChromeDriver Python Tests
Summary: Add ChromeDriver python Desktop Tests to Commit Queue (was: Add ChromeDriver Tests in Commit Queue)
Blocking: chromedriver:2282

Sign in to add a comment