New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793369 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD Extensions] Sidebar not closing when selecting current page.

Project Member Reported by dpa...@chromium.org, Dec 8 2017

Issue description

Repro (see screencast):

1) Go to chrome://extensions
2) Open the sidebar
3) Click on "Extensions"

Expected:
Sidebar should close.

Actual:
Sidebar not closing.

This is not consistent with what Settings sidenav does.
 
sidebar_not_closing.mp4
893 KB View Download
Owner: scottchen@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f097ef96b8aeb7cb0950aa8d1fe798f2285daf18

commit f097ef96b8aeb7cb0950aa8d1fe798f2285daf18
Author: Scott Chen <scottchen@chromium.org>
Date: Tue Dec 12 21:02:51 2017

MD Extensions: animate-close sidebar when link clicked

Bug:  793369 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If5b0fe0db0ddbbacce655ef90cd8fe3d135982d0
Reviewed-on: https://chromium-review.googlesource.com/817939
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523537}
[modify] https://crrev.com/f097ef96b8aeb7cb0950aa8d1fe798f2285daf18/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/f097ef96b8aeb7cb0950aa8d1fe798f2285daf18/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/f097ef96b8aeb7cb0950aa8d1fe798f2285daf18/chrome/browser/resources/md_extensions/sidebar.js
[modify] https://crrev.com/f097ef96b8aeb7cb0950aa8d1fe798f2285daf18/chrome/test/data/webui/extensions/extension_sidebar_test.js

Status: fixed (was: Started)

Sign in to add a comment