Misplaced touch-selection handles in OOPIFs which are pinched-zoomed. |
|||
Issue descriptionChrome Version: 65.0.3288.1 (Official Build) canary SyzyASan (32-bit) OS: Windows 10 What steps will reproduce the problem? (1) Open a page with OOPIF and pinch zoom. (2) Select something until handles What is the expected result? Handles appear correctly. What happens instead? They are misplaced. Also not related to selection handles, but the OOPIF is looking really poor quality.
,
Dec 8 2017
I'm not sure that the handle misplacement is due to Issue 654917 , but the poor quality appearance is. Let's keep the handle issue separate.
,
Dec 8 2017
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7f4ab11cf9b65467aab860edc38e613d604b37d commit a7f4ab11cf9b65467aab860edc38e613d604b37d Author: W. James MacLean <wjmaclean@chromium.org> Date: Wed Dec 13 00:37:55 2017 Fix coordinates for selection handles when page_scale != 1 This CL revises the calculations used by the child frame touch selection controller client when converting child-frame coordinates to the root frame coord space. The old calculations failed to take into account the page scale factor. This CL also removes RenderWidgetHostViewChildFrame::GetViewOriginInRoot(), which is now obsolete. Bug: 793363 Change-Id: I48766c396193b243d7336304bbf87734b5a41689 Reviewed-on: https://chromium-review.googlesource.com/820014 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#523625} [modify] https://crrev.com/a7f4ab11cf9b65467aab860edc38e613d604b37d/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc [modify] https://crrev.com/a7f4ab11cf9b65467aab860edc38e613d604b37d/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc [modify] https://crrev.com/a7f4ab11cf9b65467aab860edc38e613d604b37d/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.h [modify] https://crrev.com/a7f4ab11cf9b65467aab860edc38e613d604b37d/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/a7f4ab11cf9b65467aab860edc38e613d604b37d/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/a7f4ab11cf9b65467aab860edc38e613d604b37d/content/browser/site_per_process_browsertest.cc
,
Jan 25 2018
This should be fixed now. Please reopen if necessary.
,
Jan 25 2018
Closing for real this time. |
|||
►
Sign in to add a comment |
|||
Comment 1 by ekaramad@chromium.org
, Dec 8 2017