Fatal error on --help if man not installed
Reported by
achrisl...@gmail.com,
Dec 8 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0 Steps to reproduce the problem: 1. Install chromium on a Linux system that does not have man installed 2. Run 'chromium-browser --help' 3. What is the expected behavior? See a help message What went wrong? Crashes: [1208/173205.259013:FATAL:chrome_main_delegate.cc(359)] execlp failed: No such file or directory #0 0x7f289b18f547 base::debug::StackTrace::StackTrace() #1 0x7f289b1afc3a logging::LogMessage::~LogMessage() #2 0x7f289b1b0179 logging::ErrnoLogMessage::~ErrnoLogMessage() #3 0x5614ce4bf54e ChromeMainDelegate::BasicStartupComplete() #4 0x7f28957415da content::ContentMainRunnerImpl::Initialize() #5 0x7f289b4f6107 service_manager::Main() #6 0x7f28957409c1 content::ContentMain() #7 0x5614ce4be0a3 ChromeMain #8 0x7f28802b8c05 __libc_start_main #9 0x5614ce4bdf22 <unknown> Aborted (core dumped) Did this work before? N/A Chrome version: 61.0.3163.100 Channel: dev OS Version: CentOS 7 Flash Version: I filed this as a bug and not a feature request because I think "help" of all things should produce a useful message and not a completely obscure stack trace. I came across this in a docker container and it wasn't easy to run strace so I checked the source code and found the issue there. Once I installed man I got "No manual entry for chromium-browser", which isn't helpful, but isn't exactly a bug.
,
Dec 8 2017
The crash is due to "PLOG(FATAL) << ..." which probably should just change to something that fails a bit more gracefully. I'm surprised we don't specify enough dependencies that indirectly pull in "man". Maybe that's because we loosened the LSB deps. Oh well. For the case of running the chrome binary directly with --help, we can either just let it be, or detect we are not running with a wrapper and show some other message. I don't have a strong pref for this. The expecation is users run "google-chrome" or "chromium-browser" from /usr/bin and not /path/to/install_dir/chrome, I would expect users to to also run "man $WRAPPER_NAME" and not "man chrome". If they do the latter, they are doing it wrong.
,
Dec 9 2017
+timbrown could you take this issue? I see two ways of moving forward: 1. If we insist on using man for our help message a. Add man-db to debian/additional_deps b. Add /usr/bin/man to rpm/additional_deps c. Use $WRAPPER_NAME instead of the binary name here https://cs.chromium.org/chromium/src/chrome/app/chrome_main_delegate.cc?rcl=900dd0f1b5215ce5146c08f71b21894065f7efe7&l=351 d. Exit gracefully if the execlp() fails 2. Display the help message from chrome. This would involve refactoring manpage.1.in so that it can be used both as a manpage and as the help message. Firefox's --help message looks pretty good. I prefer (2) but if you decide to take this issue, please do whatever you think is best.
,
Dec 9 2017
(3) Maybe just display a short help message and call it a day.
,
Dec 11 2017
(3) is also acceptable.
,
Dec 12
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 12
,
Jan 11
Available, but no owner or component? Please find a component, as no one will ever find this without one. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thomasanderson@chromium.org
, Dec 8 2017Status: Available (was: Unconfirmed)
+thestig Running "google-chrome-stable --help" does execve("man google-chrome-stable"). If I do "out/.../chrome --help", then I get an error saying "No manual entry for chrome". Also FYI, man is provided by man-db, which we don't seem to depend on. wdyt we should do?