New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 793346 link

Starred by 1 user
Status: Assigned
Owner:
█ ashleymarie@chromium.org
Last visit > 30 days ago
Cc:
eyaich@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Need to pass perf-id and results-url to merge script

Project Member Reported by ashleymarie@chromium.org, Dec 8 2017 
Currently, the merge script is passed a few arguments in the following form:

  <merge_script> \
            [--build-properties <string JSON>] \
            [merge arguments...] \
            --summary-json <summary json> \
            -o <merged json path> \
            <shard json>...

https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/swarming/resources/collect_task.py

perf-id and results-url do not live in build properties but we need these arguments in order to upload results to the perf dashboard in the perf specific merge (merge and upload) script.

I need to figure out 1) what are perf-id and results-url, 2) if they should be in build properties or just in the merge arguments which I think are defined here: https://cs.chromium.org/chromium/src/tools/perf/chromium.perf.fyi.extras.json?l=292

Comment 1 by ashleymarie@chromium.org, Dec 8 2017 

Turns out perf-id is the not pretty name defined in https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_perf.py?type=cs&q=chromium-rel-mac11-air&sq=package:chromium&l=126
For example: chromium-rel-win7-gpu-ati

There's a lot that's going to be changed in the places that use it so I'm not going to mess with its name for now.

In the upload_perf_dashboard_results.py file I'm moving to src/tools/perf, I will rename that to configuration_name since that makes way more sense.

Since both of them are constant for a given bot, I can just pass them through in the merge arguments which makes this all much easier
►

Sign in to add a comment