New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 793334 link

Starred by 1 user
Status: Assigned
Owner:
█ lalitm@chromium.org
Last visit > 30 days ago
Cc:
primiano@chromium.org
█ hjd@chromium.org
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Hotlist-MemoryInfra



Sign in to add a comment

Tracker bug for moving tracing to use new graph computation code in Chrome

Project Member Reported by lalitm@chromium.org, Dec 8 2017 
With crbug/768373 now complete, we should move tracing over to use this new graph computation system.

We have already verified in some simple cases that the effective size computation is working as intended but more work is needed to verify this on a large scale.

We will probably add a Chrome flag to toggle whether the old or new system is used and ensure we get the same results in both cases.

Comment 1 by lalitm@chromium.org, Dec 20 2017 

Accidentally put wrong bug number but below CL refers to this bug:

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/948a3fea9e7bc2dd864ac8bf7785705b528d44c1

commit 948a3fea9e7bc2dd864ac8bf7785705b528d44c1
Author: Lalit Maganti <lalitm@chromium.org>
Date: Tue Dec 19 19:32:39 2017

memory-infra: add code to serialize the process dump graph

Add the code to serialize the memory graph and also add a command line
flag to switch whether we want to utilise the graph when adding dump
info to tracing.

Bug:   768373  
Change-Id: I2667609b75d3cf339649913284a2fc1c12669853
Reviewed-on: https://chromium-review.googlesource.com/809129
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Reviewed-by: Hector Dearman <hjd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525111}
[modify] https://crrev.com/948a3fea9e7bc2dd864ac8bf7785705b528d44c1/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/948a3fea9e7bc2dd864ac8bf7785705b528d44c1/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/948a3fea9e7bc2dd864ac8bf7785705b528d44c1/services/resource_coordinator/memory_instrumentation/graph.cc
[modify] https://crrev.com/948a3fea9e7bc2dd864ac8bf7785705b528d44c1/services/resource_coordinator/memory_instrumentation/graph.h
[modify] https://crrev.com/948a3fea9e7bc2dd864ac8bf7785705b528d44c1/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
[modify] https://crrev.com/948a3fea9e7bc2dd864ac8bf7785705b528d44c1/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.h
[add] https://crrev.com/948a3fea9e7bc2dd864ac8bf7785705b528d44c1/services/resource_coordinator/memory_instrumentation/switches.cc
[add] https://crrev.com/948a3fea9e7bc2dd864ac8bf7785705b528d44c1/services/resource_coordinator/memory_instrumentation/switches.h
[modify] https://crrev.com/948a3fea9e7bc2dd864ac8bf7785705b528d44c1/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer.h
►

Sign in to add a comment