New issue
Advanced search Search tips

Issue 793332 link

Starred by 1 user
Status: Archived
Owner:
dtseng@chromium.org
Closed: Dec 2017
Cc:
dtseng@chromium.org
lpalmaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox find in page not working right

Project Member Reported by lpalmaro@chromium.org, Dec 8 2017 
OS: Chrome
Version: 65.0.3286.0

1) press Search Slash to open the find in page in the panel
2) type a query
3) press down arrow to cycle through found results
4) press enter to shift focus to one of the results


What should happen:
Focus should move to that result and you should be able to continue reading/navigating from that point. Also, the panel should resume displaying speech/braille captions 

What is happening:
Pressing Enter doesn't shift your focus to that result. 
Also, the panel does not resume with speech captions - the query stays there. And, if you press Search Slash again and delete the query, the hint text "find in page" still remains but captions don't come back until you disable and reenable ChromeVox.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff3f3c9790db6bd2708d04ba4e62e9d518fa1de8

commit ff3f3c9790db6bd2708d04ba4e62e9d518fa1de8
Author: David Tseng <dtseng@chromium.org>
Date: Sat Dec 09 01:24:54 2017

Fix two focus recovery paths

- focus handler once used live, runtime AutomationNode objects to
restore position.  We now restore using hit testing (via
maybeRecoverFocusAndOutput_), so this code is no longer needed.

- a small change, but important one to load complete. We want to always
  trigger restoration in a load complete, even if it is for the same
  url.

Test:

1. use incremental search on a page. Ensure to select/enter a search
result that lands on a focusable item. Verify that once you hit enter,
ChromeVox doesn't "recover" back to the previous item.

2. alt tab back and forth between two open windows. Verify recovery works and triggers the hit test recovery path.

Bug:  793332 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8c950945ba22b6f3962d23222c1285fefa16dadf
Reviewed-on: https://chromium-review.googlesource.com/818019
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522954}
[modify] https://crrev.com/ff3f3c9790db6bd2708d04ba4e62e9d518fa1de8/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/ff3f3c9790db6bd2708d04ba4e62e9d518fa1de8/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d94b230e22596f4b2d0b0d1a84d8e017e254fafb

commit d94b230e22596f4b2d0b0d1a84d8e017e254fafb
Author: David Tseng <dtseng@chromium.org>
Date: Tue Dec 12 03:58:25 2017

Fix panel search visibility


Bug:  793332 

Test: $('speech-container').hidden is false; Search+/; $('speech-container').hidden is true; escape or enter; $('speech-container').hidden is false and $('search-container').hidden is true

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If8a0241140086c4089dc495fd83f8f54db4333a5
Reviewed-on: https://chromium-review.googlesource.com/820044
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523320}
[modify] https://crrev.com/d94b230e22596f4b2d0b0d1a84d8e017e254fafb/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

Comment 3 by dtseng@chromium.org, Dec 22 2017

Status: fixed (was: Assigned)

Comment 4 by dchan@google.com, Jul 30

Status: Archived (was: Fixed)
►

Sign in to add a comment