New issue
Advanced search Search tips

Issue 793330 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility

Blocking:
issue 719015



Sign in to add a comment

Notifications on lock are not accessible via ChromeVox

Project Member Reported by jdufault@chromium.org, Dec 8 2017

Issue description

From issue 757273 comment 3:

When using keyboard only and you tab to the notifications button and press space, then the little dialog appears saying that you should sign in to view notifications. Currently, you can't press escape to close that and you should be able to. Also, what is the point of that little arrow button in that UI? I hear "close settings" as the button label when using ChromeVox, but it doesn't do anything that I can see? 
 
Blocking: 719015

Comment 2 by shihuis@google.com, Dec 8 2017

Components: UI>Accessibility>ChromeVox
Status: Started (was: Assigned)
Part with the arrow was a bug and is already fixed:
https://bugs.chromium.org/p/chromium/issues/detail?id=797861 
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/871469bf2bd6618cf146c36886ecf4c821af45b8

commit 871469bf2bd6618cf146c36886ecf4c821af45b8
Author: Aga Wronska <agawronska@chromium.org>
Date: Fri Feb 02 18:07:17 2018

Make message center label accessible via ChromeVox on lock screen.

Message center label on lock screen provides user with the information
that device needs to be unlocked for access to notifications. This
information needs to be announced by ChromeVox. Announcement for the
label is not needed in unlocked state. Message center should be dismissed
by pressing Esc on the keyboard.

* Make notification label focusable on lock screen so it gets announcement.
* Move accessibility node information to MessageCenterButtonBar, because
otherwise they are not available when needed.
* Move button bar title to MessageCenterButtonBar to avoid the round
trip to fetch it.
* Remove MessageScrollView because it is no longer needed.

Bug:  793330 
Change-Id: Ida23d2557973cbcd182d7ea4d2ee3ebec5a100bc
Reviewed-on: https://chromium-review.googlesource.com/894990
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534095}
[modify] https://crrev.com/871469bf2bd6618cf146c36886ecf4c821af45b8/ash/message_center/message_center_button_bar.cc
[modify] https://crrev.com/871469bf2bd6618cf146c36886ecf4c821af45b8/ash/message_center/message_center_button_bar.h
[modify] https://crrev.com/871469bf2bd6618cf146c36886ecf4c821af45b8/ash/message_center/message_center_view.cc
[modify] https://crrev.com/871469bf2bd6618cf146c36886ecf4c821af45b8/ash/message_center/message_center_view.h

Status: Fixed (was: Started)

Sign in to add a comment