New issue
Advanced search Search tips

Issue 793323 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Remove old PassKit code

Project Member Reported by eugene...@chromium.org, Dec 8 2017

Issue description

Remove code from BVC, Tab, CRWWebController. 
 
Components: Internals
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Restrict-View-Google M-67
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5

commit ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5
Author: Eugene But <eugenebut@google.com>
Date: Mon Mar 12 17:24:10 2018

Removed old PassKit code and feature flag.

Bug:  793323 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id1cb2ae98a0969fe324e3c521e6414c81152d23b
Reviewed-on: https://chromium-review.googlesource.com/957427
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542524}
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/download/browser_download_service.mm
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/download/browser_download_service_unittest.mm
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/prerender/preload_controller.mm
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/ui/browser_view_controller_dependency_factory.h
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/chrome/browser/web/BUILD.gn
[delete] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/ios/chrome/browser/web/passkit_dialog_provider.h
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/web/BUILD.gn
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/web/features.mm
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/web/public/features.h
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/web/public/web_state/ui/crw_web_delegate.h
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/web/web_state/BUILD.gn
[delete] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/ios/web/web_state/crw_pass_kit_downloader.h
[delete] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/ios/web/web_state/crw_pass_kit_downloader.mm
[delete] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/ios/web/web_state/crw_pass_kit_downloader_unittest.mm
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/web/web_state/ui/BUILD.gn
[modify] https://crrev.com/ac47020c9ff7ae7c7e54e53a8efd1bde974d69c5/ios/web/web_state/ui/crw_web_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment