New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793317 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Restricted web sites failed to load with ERR_FAILED

Project Member Reported by eugene...@chromium.org, Dec 8 2017

Issue description

App Version (from "Chrome Settings > About Chrome"): M63
iOS Version: iOS 11.2
Device: iPhone SE

Steps to reproduce: 
1.) Go to Settings > General > Restrictions > Web Sites
2.) Choose Specific Websites only
3.) Launch Chrome and load google.com

Observed behavior: 
This site can't be reached error is displayed

Expected behavior: 
You can not browse this page at "google.com" because it is restricted error should be displayed.

Works fine in Safari and Firefox.

 
Cc: shrike@chromium.org
Labels: OS-Mac
On Chrome Mac the load also fails without giving an error page.
Cc: mard...@chromium.org
Mardini, could you please weight on priority for supporting Restrictions. It will probably take a few days of Eng work + some input from UX.
Supervised users are getting deprecated so I wouldn't prioritize this work at all.
Oh wait. Sorry, I thought this is related to supervised users because of the component. Anyway, I wouldn't prioritize this work at this point honestly. I don't think it's high impact.

Comment 5 by pkl@chromium.org, Dec 11 2017

Cc: pinkerton@chromium.org pkl@chromium.org
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)
Components: -Services>SupervisedUser
Components: Mobile>WebView>Glue
Cc: bauerb@chromium.org
Components: -Mobile>WebView>Glue UI>Browser>TabContents
bauerb@, Is there a reason for removing Services>SupervisedUser? Seems like appropriate component to me according to component description.

Comment 9 by bau...@google.com, Mar 8 2018

The bug is about OS-level restrictions; "Supervised Users" is a specific Chrome feature (which never launched on iOS). 
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2233628f5f5b32c7b458428f8d5cfbd0a18be82e

commit 2233628f5f5b32c7b458428f8d5cfbd0a18be82e
Author: Danyao Wang <danyao@chromium.org>
Date: Sat Apr 14 17:14:06 2018

[Nav Experiment] Skip native error if URL is blocked by content filter.

When a URL is blocked due to Restrictions settings, WKWebView triggers
|webView:didFailProvisionalNavigation| and automatically triggers a
second navigation that loads an error page. Without this change, Chrome
injects an extra navigation entry for displaying native error, which
shows up after the system "Access Restricted" error.

Bug:  831381 , 793317 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaafcc8f1c5abde120ad10d0794832ab09abeec6d
Reviewed-on: https://chromium-review.googlesource.com/1012470
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550898}
[modify] https://crrev.com/2233628f5f5b32c7b458428f8d5cfbd0a18be82e/ios/web/public/web_kit_constants.h
[modify] https://crrev.com/2233628f5f5b32c7b458428f8d5cfbd0a18be82e/ios/web/web_state/ui/crw_web_controller.mm

Status: Fixed (was: Available)
Labels: Needs-Feedback
@Danyao Wang: As the steps mentioned in comment#0 can't be performed on Mac OS, hence requesting you to provide the steps to be done on Mac in order to verify the fix.

Thanks!

Comment 13 by pkl@chromium.org, Apr 17 2018

Owner: danyao@chromium.org
Labels: -OS-Mac
The bug was only fixed for iOS. We should probably file a separate bug for mac. For now, I'm just removing Mac checkbox. 
> The bug was only fixed for iOS. We should probably file a separate bug for mac. For now, I'm just removing Mac checkbox. 

No one on the Mac team knows this - options are to ping someone on the Mac team, open this bug on OS=Mac, leave this bug open but change it to OS=Mac. As it stands, this bug has just been silently dropped for OS=Mac.

Filed a separate bug for Mac:  crbug.com/833879 
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2233628f5f5b32c7b458428f8d5cfbd0a18be82e

commit 2233628f5f5b32c7b458428f8d5cfbd0a18be82e
Author: Danyao Wang <danyao@chromium.org>
Date: Sat Apr 14 17:14:06 2018

[Nav Experiment] Skip native error if URL is blocked by content filter.

When a URL is blocked due to Restrictions settings, WKWebView triggers
|webView:didFailProvisionalNavigation| and automatically triggers a
second navigation that loads an error page. Without this change, Chrome
injects an extra navigation entry for displaying native error, which
shows up after the system "Access Restricted" error.

Bug:  831381 , 793317 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaafcc8f1c5abde120ad10d0794832ab09abeec6d
Reviewed-on: https://chromium-review.googlesource.com/1012470
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550898}
[modify] https://crrev.com/2233628f5f5b32c7b458428f8d5cfbd0a18be82e/ios/web/public/web_kit_constants.h
[modify] https://crrev.com/2233628f5f5b32c7b458428f8d5cfbd0a18be82e/ios/web/web_state/ui/crw_web_controller.mm

Verified in 68.0.3405.0 Canary in iPhone 8plus(iOS 11.2.6) and ipad Mini(iOS 10.3.3)

Slim navigation is disabled: This site can't be reached error is displayed
Slim navigation is enabled: Restricted site webpage is displayed



Project Member

Comment 19 by bugdroid1@chromium.org, May 23 2018

Labels: merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5997eb8bc1adef874d95ac6a78ec8d39d0b60491

commit 5997eb8bc1adef874d95ac6a78ec8d39d0b60491
Author: Danyao Wang <danyao@chromium.org>
Date: Wed May 23 16:03:41 2018

[Nav Experiment] Skip native error if URL is blocked by content filter.

Cherrypick to refs/branch-heads/3396.

When a URL is blocked due to Restrictions settings, WKWebView triggers
|webView:didFailProvisionalNavigation| and automatically triggers a
second navigation that loads an error page. Without this change, Chrome
injects an extra navigation entry for displaying native error, which
shows up after the system "Access Restricted" error.

Bug:  831381 , 793317 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaafcc8f1c5abde120ad10d0794832ab09abeec6d
Reviewed-on: https://chromium-review.googlesource.com/1012470
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550898}(cherry picked from commit 2233628f5f5b32c7b458428f8d5cfbd0a18be82e)
Reviewed-on: https://chromium-review.googlesource.com/1070408
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#685}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/5997eb8bc1adef874d95ac6a78ec8d39d0b60491/ios/web/public/web_kit_constants.h
[modify] https://crrev.com/5997eb8bc1adef874d95ac6a78ec8d39d0b60491/ios/web/web_state/ui/crw_web_controller.mm

Status: Verified (was: Fixed)
Verified in:

App Version: 67.0.3396.59 beta
Devices: iPhone 7, iPhone 8, iPad Mini
iOS Versions: 10.3.3, 11.2.6, 11.4 beta 6

'Access Restricted' error is displayed, navigating to restricted websites.

Sign in to add a comment