New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793308 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Highlight CLs authored by signed-in user

Project Member Reported by rsesek@chromium.org, Dec 8 2017

Issue description

Version: 2452-d123a4e

On the console view (and maybe other views), it would be convenient to highlight any rows for CLs that you landed, so you can easily see their progress. This could be accomplished by using the email(s, to handle @google.com and @chromium.org?) from the logged-in user.

Adding this feature could replace this extension: https://chrome.google.com/webstore/detail/highlight-me-in-buildbot/fkkgaddlippjidimcfbpllllclgnikdb?hl=en
 

Comment 1 by no...@chromium.org, Dec 8 2017

Cc: efoo@chromium.org
note that typically chromium commits are made with chromium.org accounts, while users usually log in to milo with google accounts. Milo is not aware of chromium.org <-> google.com association.

If users log in with chromium accounts, then they won't see internal builds and/or highlighting won't work for internal builds (that are made with google accounts).

bug 781611 is about improving the way we check access. If it is done, then chromium.org  accounts will start seeing internal builds, but highlighting will still not work for them.

Associating chromium.org with google.com accounts in Milo does not sound trivial. I think the best tradeoff is to finish bug 781611 and implement basic "email matches" check. The latter does not have to wait for bug 781611 though.

+efoo for tracking
A low-tech option would just be to allow users to enter a list of emails they'd like highlighted (that's what the extension does).

Comment 3 by no...@chromium.org, Dec 8 2017

Labels: -Type-Bug Type-Feature
yeah, that would work too. it requires re-introducing user settings

Comment 4 by efoo@chromium.org, Dec 8 2017

Labels: LUCI-Afterglow LUCI-KnownIssues-UI
Status: Available (was: Untriaged)
Adding labels for tracking. 
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 10

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: dpranke@google.com
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Maybe Dirk has an opinion.
I don't have a strong opinion here. Ideally, sure, something like matching against a specified set of emails would be nice, and being able to manage that set across multiple tools would be nice.

But, it's likely a fair amount of work to do this well everywhere and not worth it just for this single feature request. It might make sense to roll this up as part of a larger request, though.

Sign in to add a comment