Failing tests with viz and surface sync |
|||
Issue descriptionI was trying to turn on surface synchronization by default when --enable-viz is turned on. However, some additional content_browsertests fail in this configuration and will need to be disabled until they can be fixed. I talked to fsamuel@ about this and he believes most of the failing tests are because of incorrect expectations and not bugs.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56914490dbbc8a5caa3b3bf9a31ef09482c77987 commit 56914490dbbc8a5caa3b3bf9a31ef09482c77987 Author: kylechar <kylechar@chromium.org> Date: Wed Dec 13 04:20:26 2017 Turn on surface sync with --enable-viz. Always turn on surface synchronization when the --enable-viz flag is present. Disable a few extra tests which now fail in the new configuration. The --enable-surface-synchronization flag was added to an FYI trybot to check for failures. No failures were observed over the weekend. Remove the now unneeded flag from the FYI trybot. Bug: 793302 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6bc0aff21d968ba5ee38f7453fbd7b5779efb34a Reviewed-on: https://chromium-review.googlesource.com/812409 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#523685} [modify] https://crrev.com/56914490dbbc8a5caa3b3bf9a31ef09482c77987/components/viz/common/features.cc [modify] https://crrev.com/56914490dbbc8a5caa3b3bf9a31ef09482c77987/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/56914490dbbc8a5caa3b3bf9a31ef09482c77987/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter [modify] https://crrev.com/56914490dbbc8a5caa3b3bf9a31ef09482c77987/testing/buildbot/filters/viz.content_browsertests.filter [modify] https://crrev.com/56914490dbbc8a5caa3b3bf9a31ef09482c77987/testing/buildbot/test_suites.pyl
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af93a1eedbc47abde6900376bdfa1d3ed1dd8f3f commit af93a1eedbc47abde6900376bdfa1d3ed1dd8f3f Author: kylechar <kylechar@chromium.org> Date: Wed Dec 13 21:57:07 2017 viz: Pass --enable-viz to renderer. Surface sync is activated with --enable-viz now, but that wasn't being passed to the renderer. This resulted in surfaces not showing up sometimes. Bug: 793302 Change-Id: Ief3a4f3a85b4ccd1b4d45d86cb4e6fcd1cf0c918 Reviewed-on: https://chromium-review.googlesource.com/825645 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#523896} [modify] https://crrev.com/af93a1eedbc47abde6900376bdfa1d3ed1dd8f3f/content/browser/renderer_host/render_process_host_impl.cc
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/338798f933ceae65be008723bb3b54f46c04d520 commit 338798f933ceae65be008723bb3b54f46c04d520 Author: kylechar <kylechar@chromium.org> Date: Thu Dec 14 15:58:17 2017 viz: Try enabling tests tests on FYI. These tests were failing because of a flag not being passed. Try enabling on FYI. TBR: jonross@chromium.org Bug: 793302 Change-Id: Ic780a2545199c7c7d81014f3650c95de1b19f57c Reviewed-on: https://chromium-review.googlesource.com/827027 Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524077} [modify] https://crrev.com/338798f933ceae65be008723bb3b54f46c04d520/testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46c228c05fd22828e23edcb2351d27d589290d1f commit 46c228c05fd22828e23edcb2351d27d589290d1f Author: kylechar <kylechar@chromium.org> Date: Thu Dec 14 21:04:44 2017 viz: Enable viz_content_browsertests. These tests were failing because of a flag not being passed which has been fixed. Bug: 793302 Change-Id: Ia5eb10f390011b27179e93e50392d97421b75101 Reviewed-on: https://chromium-review.googlesource.com/826868 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524173} [modify] https://crrev.com/46c228c05fd22828e23edcb2351d27d589290d1f/testing/buildbot/filters/viz.content_browsertests.filter
,
Jan 8 2018
,
Jan 25 2018
The surface sync work seems to have fixed these. I'll reenable |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 8 2017