New issue
Advanced search Search tips

Issue 793300 link

Starred by 1 user
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Compile failing due to Android Lint warnings

Project Member Reported by agrieve@chromium.org, Dec 8 2017 
Not sure if any bots are broken, but after syncing & building this morning I get:

Wrote XML report to file:///usr/local/google/home/agrieve/ssd/git/clankium1/src/out-gn/Debug/gen/chrome/android/chrome_java__lint/result.xml
Lint found 1 error, 2 warnings


/tmp/tmpiSThF2/SRC_ROOT1/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageOrigin.java:154 Reading app signatures from getPackageInfo: The app signatures could be exploited if not validated properly; see issue explanation for details.: PackageManagerGetSignatures [warning]
                    packageManager.getPackageInfo(appName, PackageManager.GET_SIGNATURES)
                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/tmpiSThF2/SRC_ROOT1/chrome/android/java/src/org/chromium/chrome/browser/browserservices/OriginVerifier.java:220 Reading app signatures from getPackageInfo: The app signatures could be exploited if not validated properly; see issue explanation for details.: PackageManagerGetSignatures [warning]
            packageInfo = pm.getPackageInfo(packageName, PackageManager.GET_SIGNATURES);
                                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/tmpiSThF2/SRC_ROOT1/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/keyboard/GvrKeyboardLoaderClient.java:33 Do not place Android context classes in static fields (static reference to `KeyboardContextWrapper` which has field `mKeyboardContext` pointing to `Context`); this is a memory leak (and also breaks Instant Run): StaticFieldLeak [warning]
    // GVR doesn't support setting the context twice in the application's lifetime and crashes if we
    ^

Lint found 3 new issues.
 - For full explanation, please refer to out-gn/Debug/gen/chrome/android/chrome_java__lint/result.xml
 - For more information about lint and how to fix lint issues, please refer to https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a43d818d47fae08b0a356b124b2c72d61039eae

commit 7a43d818d47fae08b0a356b124b2c72d61039eae
Author: Andrew Grieve <agrieve@chromium.org>
Date: Fri Dec 08 16:24:18 2017

Android: Suppress a few lint warnings

Causing my local build to break. They all appear to be false-positives.

TBR=mariakhomenko

Bug:  793300 
Change-Id: I16389fae3bf49973bb7be1e45c89b5a9df1eced3
Reviewed-on: https://chromium-review.googlesource.com/817534
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522789}
[modify] https://crrev.com/7a43d818d47fae08b0a356b124b2c72d61039eae/chrome/android/java/src/org/chromium/chrome/browser/browserservices/OriginVerifier.java
[modify] https://crrev.com/7a43d818d47fae08b0a356b124b2c72d61039eae/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageOrigin.java
[modify] https://crrev.com/7a43d818d47fae08b0a356b124b2c72d61039eae/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/keyboard/GvrKeyboardLoaderClient.java

Comment 2 by agrieve@chromium.org, Dec 8 2017

Status: Fixed (was: Assigned)

Comment 3 by estevenson@chromium.org, Dec 14 2017 

Seeing something similar after syncing recently myself:

Wrote XML report to file:///usr/local/google/code/clankium/src/out/Release/gen/chrome/android/chrome_java__lint/result.xml
Lint found 3 errors, 1 warning


/tmp/tmp47EUta/SRC_ROOT1/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java:255 The id `R.id.password_entry_editor_copy` has already been looked up in this method; possible cut & paste error?: CutPasteId [warning]
        final ImageView copy_image = usernameView.findViewById(R.id.password_entry_editor_copy);
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/tmp47EUta/SRC_ROOT1/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java:283 The id `R.id.password_entry_editor_copy` has already been looked up in this method; possible cut & paste error?: CutPasteId [warning]
        final ImageView copy_image = siteView.findViewById(R.id.password_entry_editor_copy);
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/tmp47EUta/SRC_ROOT1/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java:362 The id `R.id.password_entry_editor_copy_password` has already been looked up in this method; possible cut & paste error?: CutPasteId [warning]
                mView.findViewById(R.id.password_entry_editor_copy_password);
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/tmp47EUta/SRC_ROOT1/chrome/android/java/src/org/chromium/chrome/browser/browserservices/OriginVerifier.java:221 Reading app signatures from getPackageInfo: The app signatures could be exploited if not validated properly; see issue explanation for details.: PackageManagerGetSignatures [warning]
            packageInfo = pm.getPackageInfo(packageName, PackageManager.GET_SIGNATURES);
                                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Lint found 4 new issues.
 - For full explanation, please refer to out/Release/gen/chrome/android/chrome_java__lint/result.xml
 - For more information about lint and how to fix lint issues, please refer to https://chromium.googlesource.com/chromium/src/+/master/build/android/docs/lint.md

Comment 4 by estevenson@chromium.org, Dec 14 2017 

Turns out this is caused by Android Studio messing with third_party/android_tools/sdk.
►

Sign in to add a comment