Findit has detected a flake at test NetworkServiceRestartBrowserTest.StoragePartitionImplGetNetworkContext. Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I5c86b02023e0540bc5bb6566c00d3bc9cb91fdbf Regression range: https://crrev.com/f2e86b3728f4fdc05379122bc6352c071feba728..a52d7d2d1782297ae4db125ee5569624c501be0c?pretty=fuller Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKWAWNocm9taXVtLm1hYy9NYWMxMC45IFRlc3RzLzUxMjYxL2NvbnRlbnRfYnJvd3NlcnRlc3RzL1RtVjBkMjl5YTFObGNuWnBZMlZTWlhOMFlYSjBRbkp2ZDNObGNsUmxjM1F1VTNSdmNtRm5aVkJoY25ScGRHbHZia2x0Y0d4SFpYUk9aWFIzYjNKclEyOXVkR1Y0ZEE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
Going to disable the test on Mac and investigate.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8185d184ea70280bacb533526506c036176fcdfe commit 8185d184ea70280bacb533526506c036176fcdfe Author: Chong Zhang <chongz@chromium.org> Date: Fri Dec 08 20:11:37 2017 Disable flaky NetworkServiceRestartBrowserTest.StoragePartitionImplGetNetworkContext on Mac TBR=fdoray@chromium.org,mmenke@chromium.org Bug: 793296 Change-Id: I822d329925a2d6ca2af0ddcedfe6e45ba0628221 Reviewed-on: https://chromium-review.googlesource.com/817980 Reviewed-by: Chong Zhang <chongz@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#522855} [modify] https://crrev.com/8185d184ea70280bacb533526506c036176fcdfe/content/browser/network_service_restart_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0dfdb630ff40fb25ba2a117c7ec07d425de7350 commit e0dfdb630ff40fb25ba2a117c7ec07d425de7350 Author: Chong Zhang <chongz@chromium.org> Date: Sat Dec 09 18:25:14 2017 Flush network_service_instance after simulating crash Make sure 'network_service_instance.cc::g_network_service' receives error notification by flushing its InterfacePtr. Related tests were potentially flaky but only observed on Mac bot. Bug: 793296 Change-Id: Ia2e3a3bcc0b2bed28b86d2b119c0fd42df939112 Reviewed-on: https://chromium-review.googlesource.com/817642 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#523006} [modify] https://crrev.com/e0dfdb630ff40fb25ba2a117c7ec07d425de7350/chrome/browser/chrome_network_service_restart_browsertest.cc [modify] https://crrev.com/e0dfdb630ff40fb25ba2a117c7ec07d425de7350/content/browser/network_service_restart_browsertest.cc [modify] https://crrev.com/e0dfdb630ff40fb25ba2a117c7ec07d425de7350/content/public/browser/network_service_instance.cc [modify] https://crrev.com/e0dfdb630ff40fb25ba2a117c7ec07d425de7350/content/public/browser/network_service_instance.h
Comment 1 by chongz@chromium.org
, Dec 8 2017Owner: chongz@chromium.org
Status: Started (was: Available)